{"id":21142,"url":"https://patchwork.libcamera.org/api/1.1/patches/21142/?format=json","web_url":"https://patchwork.libcamera.org/patch/21142/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240902154212.1281257-14-mzamazal@redhat.com>","date":"2024-09-02T15:42:06","name":"[v3,13/18] libcamera: libcamera: Remove unused includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"745b926fe583c8737644cc77b4eb74510e85f47d","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21142/mbox/","series":[{"id":4556,"url":"https://patchwork.libcamera.org/api/1.1/series/4556/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4556","date":"2024-09-02T15:41:53","name":"Remove unused includes","version":3,"mbox":"https://patchwork.libcamera.org/series/4556/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21142/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21142/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A784C3259\n\tfor ;\n\tMon, 2 Sep 2024 15:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5538634F6;\n\tMon, 2 Sep 2024 17:43:00 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C879634E4\n\tfor ;\n\tMon, 2 Sep 2024 17:42:58 +0200 (CEST)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-367-J4VDT2TOMF-Em11h3VddgQ-1;\n\tMon, 02 Sep 2024 11:42:56 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 6FDDD1954B1E; Mon, 2 Sep 2024 15:42:55 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1B05E1955F1B; Mon, 2 Sep 2024 15:42:53 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HHHIV4Lp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291777;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=qGn6jAWmjiUriv+yVBp+G56xn69RS5S5KNQBuOuBgAo=;\n\tb=HHHIV4Lpum3FwRKR8SX2ROQ+zyuS10FPUuTJEZm+MkXVqSdcHkvGW8pUOR+ppgKi3NUInC\n\tBa/FQ0pFRhT0NyuuRRKg6CQA3gV4mJ42RB7VKGGuKHVI4GtbvC+PN1D26TR6BDPR1A34Lq\n\tCBkZIeeMlyqYeQ7tfAq5K0UuoTz/Ta4=","X-MC-Unique":"J4VDT2TOMF-Em11h3VddgQ-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 13/18] libcamera: libcamera: Remove unused includes","Date":"Mon, 2 Sep 2024 17:42:06 +0200","Message-ID":"<20240902154212.1281257-14-mzamazal@redhat.com>","In-Reply-To":"<20240902154212.1281257-1-mzamazal@redhat.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The includes that are not used can be removed. Additionally, add some\ndirectly used includes not listed.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/base/event_dispatcher_poll.cpp | 2 --\n src/libcamera/camera.cpp | 2 --\n src/libcamera/controls.cpp | 1 -\n src/libcamera/converter/converter_v4l2_m2m.cpp | 1 -\n src/libcamera/formats.cpp | 3 ---\n src/libcamera/ipa_module.cpp | 1 -\n src/libcamera/ipa_proxy.cpp | 1 -\n src/libcamera/orientation.cpp | 1 -\n src/libcamera/pipeline_handler.cpp | 1 -\n src/libcamera/process.cpp | 1 -\n src/libcamera/sensor/camera_sensor.cpp | 2 --\n src/libcamera/shared_mem_object.cpp | 1 -\n src/libcamera/stream.cpp | 2 --\n 13 files changed, 19 deletions(-)","diff":"diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\nindex b737ca7a..194d7bd2 100644\n--- a/src/libcamera/base/event_dispatcher_poll.cpp\n+++ b/src/libcamera/base/event_dispatcher_poll.cpp\n@@ -7,8 +7,6 @@\n \n #include \n \n-#include \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 61925e83..9d1ae696 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -9,7 +9,6 @@\n \n #include \n #include \n-#include \n \n #include \n #include \n@@ -21,7 +20,6 @@\n \n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_controls.h\"\n-#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/request.h\"\n \ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 11d35321..67400797 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -7,7 +7,6 @@\n \n #include \n \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 006ba9f7..e4f656da 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -8,7 +8,6 @@\n \n #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n \n-#include \n #include \n \n #include \ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 1d1d9a30..3ee89590 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -7,9 +7,6 @@\n \n #include \"libcamera/internal/formats.h\"\n \n-#include \n-#include \n-\n #include \n #include \n \ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 0756b691..86d88a86 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -8,7 +8,6 @@\n #include \"libcamera/internal/ipa_module.h\"\n \n #include \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex 69975d8f..85004737 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -7,7 +7,6 @@\n \n #include \"libcamera/internal/ipa_proxy.h\"\n \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\nindex fd191197..bf960249 100644\n--- a/src/libcamera/orientation.cpp\n+++ b/src/libcamera/orientation.cpp\n@@ -8,7 +8,6 @@\n #include \n \n #include \n-#include \n \n /**\n * \\file orientation.h\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex b18b6d0b..e5940469 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -22,7 +22,6 @@\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n-#include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/request.h\"\n #include \"libcamera/internal/tracepoints.h\"\ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 86d27b2d..c0f4d49f 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -10,7 +10,6 @@\n #include \n #include \n #include \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex c6d7f801..1382081a 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -10,7 +10,6 @@\n \n #include \n #include \n-#include \n #include \n #include \n #include \n@@ -24,7 +23,6 @@\n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n-#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/sysfs.h\"\n \n /**\ndiff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\nindex d4c7991a..65b53919 100644\n--- a/src/libcamera/shared_mem_object.cpp\n+++ b/src/libcamera/shared_mem_object.cpp\n@@ -10,7 +10,6 @@\n \n #include \"libcamera/internal/shared_mem_object.h\"\n \n-#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 053cc4b8..e70688f6 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -9,9 +9,7 @@\n \n #include \n #include \n-#include \n #include \n-#include \n \n #include \n \n","prefixes":["v3","13/18"]}