{"id":21136,"url":"https://patchwork.libcamera.org/api/1.1/patches/21136/?format=json","web_url":"https://patchwork.libcamera.org/patch/21136/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240902154212.1281257-7-mzamazal@redhat.com>","date":"2024-09-02T15:41:59","name":"[v3,06/18] libcamera: rkisp1: Formatting improvements","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c8fed068960e3a5f55b1b38d2c45881e14d2254f","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21136/mbox/","series":[{"id":4556,"url":"https://patchwork.libcamera.org/api/1.1/series/4556/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4556","date":"2024-09-02T15:41:53","name":"Remove unused includes","version":3,"mbox":"https://patchwork.libcamera.org/series/4556/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21136/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21136/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 930EABF415\n\tfor ;\n\tMon, 2 Sep 2024 15:42:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46FCC634F2;\n\tMon, 2 Sep 2024 17:42:49 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75267634E4\n\tfor ;\n\tMon, 2 Sep 2024 17:42:47 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-313-gxvljHKoPlaUafc7CovU5Q-1;\n\tMon, 02 Sep 2024 11:42:43 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 0C8B71955F67; Mon, 2 Sep 2024 15:42:42 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 572271955F1B; Mon, 2 Sep 2024 15:42:40 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"etxV6gij\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291766;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=n9B7xzpNdpp/51zy7HJ9SMGJRmbpGy6BPVbK8cv6ZD8=;\n\tb=etxV6gijjBZL87qJURG/DxI3hPUWXKEX3oHyAOZpWn3EaK+3j1EJZAOzc7hd2mxJCWeuu7\n\tnyLFd9UKu5NuUfSunP2Qwo4TOTApmwCJsFhT05eMt08LV2BZmxJUpudtsr+96ODFVodq3Z\n\tvbbStSXoEU1N9GcI9bfuXohtp45e+NM=","X-MC-Unique":"gxvljHKoPlaUafc7CovU5Q-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 06/18] libcamera: rkisp1: Formatting improvements","Date":"Mon, 2 Sep 2024 17:41:59 +0200","Message-ID":"<20240902154212.1281257-7-mzamazal@redhat.com>","In-Reply-To":"<20240902154212.1281257-1-mzamazal@redhat.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The LSP autoformatter doesn't like some of the current formatting, let's\nmake it happier. Note that not all of its suggestions were accepted\nbecause readability is preferred and adjusting .clang-format may not be\neasy or possible.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 3 ++-\n src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex c6451719..955a9ff4 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -306,7 +306,8 @@ void Awb::process(IPAContext &context,\n \tactiveState.awb.gains.automatic.blue = blueGain;\n \tactiveState.awb.gains.automatic.green = 1.0;\n \n-\tLOG(RkISP1Awb, Debug) << std::showpoint\n+\tLOG(RkISP1Awb, Debug)\n+\t\t<< std::showpoint\n \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n \t\t<< activeState.awb.gains.automatic.green << \", \"\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex a62fe151..f164d7c5 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -165,8 +165,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \t\treturn -ENODEV;\n \t}\n \n-\tcontext_.configuration.sensor.lineDuration = sensorInfo.minLineLength\n-\t\t\t\t\t\t * 1.0s / sensorInfo.pixelRate;\n+\tcontext_.configuration.sensor.lineDuration =\n+\t\tsensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n \n \t/* Load the tuning data file. */\n \tFile file(settings.configurationFile);\n","prefixes":["v3","06/18"]}