{"id":21125,"url":"https://patchwork.libcamera.org/api/1.1/patches/21125/?format=json","web_url":"https://patchwork.libcamera.org/patch/21125/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830210313.30691-2-chenghaoyang@chromium.org>","date":"2024-08-30T21:00:19","name":"[v3,1/3] libcamera: Add rectangle two-point constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bf7c3623e53907c2d7186ff1ca30e15305e23f91","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21125/mbox/","series":[{"id":4553,"url":"https://patchwork.libcamera.org/api/1.1/series/4553/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4553","date":"2024-08-30T21:00:18","name":"Add Face Detection Controls","version":3,"mbox":"https://patchwork.libcamera.org/series/4553/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21125/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21125/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76644C323E\n\tfor ;\n\tFri, 30 Aug 2024 21:03:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D29563469;\n\tFri, 30 Aug 2024 23:03:20 +0200 (CEST)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D08B66341E\n\tfor ;\n\tFri, 30 Aug 2024 23:03:16 +0200 (CEST)","by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-37189d8e637so1427218f8f.3\n\tfor ;\n\tFri, 30 Aug 2024 14:03:16 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3749efb37efsm4935529f8f.109.2024.08.30.14.03.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Aug 2024 14:03:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Znn+t7K0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725051796; x=1725656596;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=G4Ba3c7hJrcxKDqyLM6k3uK9nWWuDQPgRDSBllLf93U=;\n\tb=Znn+t7K0GAUgJ3mYyU1es3M17E7h7Hu4T5zObvWyyrz7HZYQGkT4QSrIs90132+93O\n\tGIpYlqZ2A/ArcaWv6zjkOhge6X4FKctOL931k/G8rsDib0CD26NHYfnIHTF5+47V5ZnO\n\tqkKMoY/qRM7zpUWbXuiBWVlj1gABdeGYCgIa4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725051796; x=1725656596;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=G4Ba3c7hJrcxKDqyLM6k3uK9nWWuDQPgRDSBllLf93U=;\n\tb=g+CrcFGmMwy5S2+faznJmaCmHkyT4Y15nIxmedT0AVjtjReXdFm1tJkOaDEV52NM5U\n\tu4q/YEEySuJYh8bPqVFka/yPsdBmGyy2twVl5Pf4wQh6N2qbu5mJ6W9S2f+y2lCZny64\n\t3i9KU+wNtOR4JYD2zImqnHEsA7FGIYa11POwMoD+Q9NhDnaZgF73qxiphsqyEW0rZGg8\n\t8XTMNdCzPn6QQbFmhsgQ4ErJ1wq+LbRR5y+L9AzJnJ3Sx0zgUCTSIm2KAhMo5YJqjXvP\n\tP057CD3+SeMwFPtEkWRje0On2lPesnQ3vgLlvZwFxKwinNcJtAC1naZL4Tqvd5MwZ3Mq\n\tkZcw==","X-Gm-Message-State":"AOJu0YwWxbX0igYGzBeRyy+M3q32jKS8hB5HWLgjj1OgDQzwEmkpB0N5\n\tDzioBwF837kgsEWSNbitrBUOiat+3stDf6E66Y5tJ8pJkG0YM94qjMxo/quf4GgiIHq3bu4FMZc\n\tQoA==","X-Google-Smtp-Source":"AGHT+IEfVzOuCShs8QkBLfsmcCXuk7hNSeaf71IT7P9hmMhUOjiHuXwtzG4n9jmLwajBDbbjtrxjTQ==","X-Received":"by 2002:adf:cd0c:0:b0:374:ba3f:d00c with SMTP id\n\tffacd0b85a97d-374bf1e4d69mr89063f8f.59.1725051795874; \n\tFri, 30 Aug 2024 14:03:15 -0700 (PDT)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Yudhistira Erlandinata ,\n\tHarvey Yang ","Subject":"[PATCH v3 1/3] libcamera: Add rectangle two-point constructor","Date":"Fri, 30 Aug 2024 21:00:19 +0000","Message-ID":"<20240830210313.30691-2-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.46.0.469.g59c65b2a67-goog","In-Reply-To":"<20240830210313.30691-1-chenghaoyang@chromium.org>","References":"<20240830210313.30691-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd a Rectangle constructor that accepts two points:\ntopLeft and bottomRight.\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \n---\n include/libcamera/geometry.h | 2 ++\n src/libcamera/geometry.cpp | 14 ++++++++++++++\n 2 files changed, 16 insertions(+)","diff":"diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 3e6f0f5d7..dc56f180f 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -262,6 +262,8 @@ public:\n \t{\n \t}\n \n+\tconstexpr Rectangle(const Point &topLeft, const Point &bottomRight);\n+\n \tint x;\n \tint y;\n \tunsigned int width;\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 000151364..029b8dad2 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -629,6 +629,20 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n * \\param[in] size The desired Rectangle size\n */\n \n+/**\n+ * \\fn Rectangle::Rectangle(const Point &topLeft, const Point &bottomRight)\n+ * \\brief Construct a Rectangle with the two given points\n+ * \\param[in] topLeft The top-left corner\n+ * \\param[in] bottomRight The bottom-right corner\n+ */\n+constexpr Rectangle::Rectangle(const Point &topLeft, const Point &bottomRight)\n+\t: x(topLeft.x), y(topLeft.y),\n+\t width(bottomRight.x - x),\n+\t height(bottomRight.y - y)\n+{\n+\tASSERT(bottomRight.x >= x && bottomRight.y >= y);\n+}\n+\n /**\n * \\var Rectangle::x\n * \\brief The horizontal coordinate of the rectangle's top-left corner\n","prefixes":["v3","1/3"]}