{"id":21121,"url":"https://patchwork.libcamera.org/api/1.1/patches/21121/?format=json","web_url":"https://patchwork.libcamera.org/patch/21121/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830152721.1420313-19-mzamazal@redhat.com>","date":"2024-08-30T15:27:15","name":"[v2,18/20] libcamera: includes: Add missing includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a5ca58658bdbdd32cd92764473a6f4ac295a81c4","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21121/mbox/","series":[{"id":4552,"url":"https://patchwork.libcamera.org/api/1.1/series/4552/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4552","date":"2024-08-30T15:26:57","name":"Remove unused includes","version":2,"mbox":"https://patchwork.libcamera.org/series/4552/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21121/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21121/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F9B1C32D5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 15:28:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFF9C634E0;\n\tFri, 30 Aug 2024 17:28:19 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17276634E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 17:28:02 +0200 (CEST)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-613-1TkKBJ3TOleqeonf9KkIZA-1;\n\tFri, 30 Aug 2024 11:27:59 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 3B02819560B0 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 15:27:59 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A86DF1955F44; Fri, 30 Aug 2024 15:27:57 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"YamCo4ne\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725031681;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=HPfavc/N+GppTSRCZi4fNlfHnYvMC1wzv9skJRWFk7I=;\n\tb=YamCo4news/tIpcEUr6bSVGnKRO6CD8dIYIGUIwYlHQur5Y4MLPCgsKy7d/PcXWwHHS9NL\n\tFS4rnchDBEMtlGJ1REgfS51Zak8jLpd8mah1BfHJNuJ3g2RkftMgbxi6KQgZxsGkbFr7y3\n\tRbqE3GkF27A1KQ6/l3V57qPIfmE/uxY=","X-MC-Unique":"1TkKBJ3TOleqeonf9KkIZA-1","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>","Subject":"[PATCH v2 18/20] libcamera: includes: Add missing includes","Date":"Fri, 30 Aug 2024 17:27:15 +0200","Message-ID":"<20240830152721.1420313-19-mzamazal@redhat.com>","In-Reply-To":"<20240830152721.1420313-1-mzamazal@redhat.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Let's add direct includes for classes currently included indirectly,\nthrough other header files.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/request.h | 1 +\n include/libcamera/logging.h          | 2 ++\n 2 files changed, 3 insertions(+)","diff":"diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex f5d98069..4e7d05b1 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -10,6 +10,7 @@\n #include <chrono>\n #include <map>\n #include <memory>\n+#include <unordered_set>\n \n #include <libcamera/base/event_notifier.h>\n #include <libcamera/base/timer.h>\ndiff --git a/include/libcamera/logging.h b/include/libcamera/logging.h\nindex e334d87b..e1c6341c 100644\n--- a/include/libcamera/logging.h\n+++ b/include/libcamera/logging.h\n@@ -7,6 +7,8 @@\n \n #pragma once\n \n+#include <ostream>\n+\n namespace libcamera {\n \n enum LoggingTarget {\n","prefixes":["v2","18/20"]}