{"id":21105,"url":"https://patchwork.libcamera.org/api/1.1/patches/21105/?format=json","web_url":"https://patchwork.libcamera.org/patch/21105/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830152721.1420313-3-mzamazal@redhat.com>","date":"2024-08-30T15:26:59","name":"[v2,02/20] libcamera: ipu3: Remove unused includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ffbf1a3b65c78e2979d370497b87f0d48345cefa","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21105/mbox/","series":[{"id":4552,"url":"https://patchwork.libcamera.org/api/1.1/series/4552/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4552","date":"2024-08-30T15:26:57","name":"Remove unused includes","version":2,"mbox":"https://patchwork.libcamera.org/series/4552/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21105/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21105/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BCDEC32D5\n\tfor ;\n\tFri, 30 Aug 2024 15:27:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1299B634CC;\n\tFri, 30 Aug 2024 17:27:39 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25B2D6341E\n\tfor ;\n\tFri, 30 Aug 2024 17:27:33 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-624-bv1r2zAGO3uJNjn1rt0oOg-1;\n\tFri, 30 Aug 2024 11:27:31 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 57C941956095 for ;\n\tFri, 30 Aug 2024 15:27:30 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 163BA1956048; Fri, 30 Aug 2024 15:27:28 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"aCZKswmA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725031652;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PJQRA5gnXHlb90quavd8QuEFBAUcGjg2/CPlNE8X2pQ=;\n\tb=aCZKswmAeEeVX1CN4tWyCfiVSf0G93DM9FMCKt6EvLiLh+mI5qJdZSGYJEYjab/u2Tcpfv\n\t9U3rMeegNXrXiEMY9Vn+e+RRQN0lLqXGh8urOWTPwDd0FUg8Jt/e1WpkmkevqA1vbrd1cJ\n\t/tlMvi9Z0r7IUoIE563U6jhWlwMZW0I=","X-MC-Unique":"bv1r2zAGO3uJNjn1rt0oOg-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[PATCH v2 02/20] libcamera: ipu3: Remove unused includes","Date":"Fri, 30 Aug 2024 17:26:59 +0200","Message-ID":"<20240830152721.1420313-3-mzamazal@redhat.com>","In-Reply-To":"<20240830152721.1420313-1-mzamazal@redhat.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/ipu3/algorithms/af.cpp | 3 ---\n src/ipa/ipu3/algorithms/agc.cpp | 1 -\n src/ipa/ipu3/algorithms/blc.cpp | 2 --\n src/ipa/ipu3/ipu3.cpp | 5 -----\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n 5 files changed, 12 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex 29eb7355..cf68fb59 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -11,7 +11,6 @@\n #include \n #include \n #include \n-#include \n #include \n #include \n #include \n@@ -23,8 +22,6 @@\n \n #include \n \n-#include \"libipa/histogram.h\"\n-\n /**\n * \\file af.h\n */\ndiff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 0e0114f6..3378c4fd 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -9,7 +9,6 @@\n \n #include \n #include \n-#include \n \n #include \n #include \ndiff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp\nindex 257f40e2..fa4b9272 100644\n--- a/src/ipa/ipu3/algorithms/blc.cpp\n+++ b/src/ipa/ipu3/algorithms/blc.cpp\n@@ -7,8 +7,6 @@\n \n #include \"blc.h\"\n \n-#include \n-\n /**\n * \\file blc.h\n * \\brief IPU3 Black Level Correction control\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex cdcdf1fb..656c51fc 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -32,12 +32,7 @@\n #include \"libcamera/internal/mapped_framebuffer.h\"\n #include \"libcamera/internal/yaml_parser.h\"\n \n-#include \"algorithms/af.h\"\n #include \"algorithms/agc.h\"\n-#include \"algorithms/algorithm.h\"\n-#include \"algorithms/awb.h\"\n-#include \"algorithms/blc.h\"\n-#include \"algorithms/tone_mapping.h\"\n #include \"libipa/camera_sensor_helper.h\"\n \n #include \"ipa_context.h\"\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2071c338..29172f34 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -6,7 +6,6 @@\n */\n \n #include \n-#include \n #include \n #include \n #include \n","prefixes":["v2","02/20"]}