{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/patches/211/?format=json","web_url":"https://patchwork.libcamera.org/patch/211/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190111165109.26803-1-jacopo@jmondi.org>","date":"2019-01-11T16:51:09","name":"[libcamera-devel] libcamera: pipeline: Add Intel IPU3 pipeline skeleton","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"ff410ef035a7a36801a55d0dd7b6bfb163039242","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/211/mbox/","series":[{"id":72,"url":"https://patchwork.libcamera.org/api/1.1/series/72/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=72","date":"2019-01-11T16:51:09","name":"[libcamera-devel] libcamera: pipeline: Add Intel IPU3 pipeline skeleton","version":1,"mbox":"https://patchwork.libcamera.org/series/72/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/211/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/211/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A4EC60B13\n\tfor ;\n\tFri, 11 Jan 2019 17:51:10 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C59D6C0008;\n\tFri, 11 Jan 2019 16:51:08 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Jan 2019 17:51:09 +0100","Message-Id":"<20190111165109.26803-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: Add Intel IPU3\n\tpipeline skeleton","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 11 Jan 2019 16:51:10 -0000"},"content":"Add a pipeline handler skeleton for the Intel IPU3 device.\nTested with on Soraka, listing detected cameras on the system and\nverifying the pipeline handler gets properly matched.\n\nSigned-off-by: Jacopo Mondi \n---\n\nLet's start by simply matching the pipeline handler with the device\nit is running on. The here created single camera gets properly enumerated\non Soraka by the 'list-cameras' test:\n\n./test/list-cameras\n[0:35:35.453249952] DBG pipeline_handler.cpp:119 Pipeline handler: \"PipeHandlerVimc\" registered\n[0:35:35.453538626] DBG pipeline_handler.cpp:119 Pipeline handler: \"PipelineHandlerIPU3\" registered\n[0:35:35.458316459] DBG device_enumerator.cpp:214 New media device: ipu3-imgu created from: /dev/media1\n[0:35:35.469071318] DBG device_enumerator.cpp:214 New media device: ipu3-cio2 created from: /dev/media0\n[0:35:35.475305874] DBG device_enumerator.cpp:255 Succesfull match for media device: ipu3-cio2\n[0:35:35.475343991] DBG device_enumerator.cpp:255 Succesfull match for media device: ipu3-imgu\n[0:35:35.475354057] DBG pipeline_handler.cpp:150 Pipeline handler: \"PipelineHandlerIPU3\" matched\n- IPU3 Camera\n\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 119 ++++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/meson.build | 3 +\n src/libcamera/pipeline/meson.build | 2 +\n 3 files changed, 124 insertions(+)\n create mode 100644 src/libcamera/pipeline/ipu3/ipu3.cpp\n create mode 100644 src/libcamera/pipeline/ipu3/meson.build\n\n--\n2.20.1","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nnew file mode 100644\nindex 0000000..477a9a2\n--- /dev/null\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -0,0 +1,119 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * ipu3.cpp - Pipeline handler for Intel IPU3\n+ */\n+\n+#include \n+\n+#include \"device_enumerator.h\"\n+#include \"media_device.h\"\n+#include \"pipeline_handler.h\"\n+\n+#include \"log.h\"\n+\n+namespace libcamera {\n+\n+class PipelineHandlerIPU3 : public PipelineHandler\n+{\n+public:\n+\tPipelineHandlerIPU3();\n+\t~PipelineHandlerIPU3();\n+\n+\tbool match(DeviceEnumerator *enumerator);\n+\n+\tunsigned int count();\n+\tCamera *camera(unsigned int id) final;\n+\n+private:\n+\tMediaDevice *cio2_;\n+\tMediaDevice *imgu_;\n+\n+\tCamera *camera_;\n+};\n+\n+PipelineHandlerIPU3::PipelineHandlerIPU3()\n+\t: cio2_(nullptr), imgu_(nullptr), camera_(nullptr)\n+{\n+}\n+\n+PipelineHandlerIPU3::~PipelineHandlerIPU3()\n+{\n+\tif (cio2_)\n+\t\tcio2_->release();\n+\tif (imgu_)\n+\t\timgu_->release();\n+\tif (camera_)\n+\t\tcamera_->put();\n+\n+\tcio2_ = nullptr;\n+\timgu_ = nullptr;\n+\tcamera_ = nullptr;\n+}\n+\n+unsigned int PipelineHandlerIPU3::count()\n+{\n+\treturn 1;\n+}\n+\n+Camera *PipelineHandlerIPU3::camera(unsigned int id)\n+{\n+\tif (id != 0)\n+\t\treturn nullptr;\n+\n+\treturn camera_;\n+}\n+\n+bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n+{\n+\tDeviceMatch cio2_dm(\"ipu3-cio2\");\n+\tcio2_dm.add(\"ipu3-csi2 0\");\n+\tcio2_dm.add(\"ipu3-cio2 0\");\n+\tcio2_dm.add(\"ipu3-csi2 1\");\n+\tcio2_dm.add(\"ipu3-cio2 1\");\n+\tcio2_dm.add(\"ipu3-csi2 2\");\n+\tcio2_dm.add(\"ipu3-cio2 2\");\n+\tcio2_dm.add(\"ipu3-csi2 3\");\n+\tcio2_dm.add(\"ipu3-cio2 3\");\n+\n+\tcio2_ = enumerator->search(cio2_dm);\n+\tif (!cio2_)\n+\t\treturn false;\n+\n+\tcio2_->acquire();\n+\n+\tDeviceMatch imgu_dm(\"ipu3-imgu\");\n+\timgu_dm.add(\"ipu3-imgu 0\");\n+\timgu_dm.add(\"ipu3-imgu 0 input\");\n+\timgu_dm.add(\"ipu3-imgu 0 parameters\");\n+\timgu_dm.add(\"ipu3-imgu 0 output\");\n+\timgu_dm.add(\"ipu3-imgu 0 viewfinder\");\n+\timgu_dm.add(\"ipu3-imgu 0 3a stat\");\n+\timgu_dm.add(\"ipu3-imgu 1\");\n+\timgu_dm.add(\"ipu3-imgu 1 input\");\n+\timgu_dm.add(\"ipu3-imgu 1 parameters\");\n+\timgu_dm.add(\"ipu3-imgu 1 output\");\n+\timgu_dm.add(\"ipu3-imgu 1 viewfinder\");\n+\timgu_dm.add(\"ipu3-imgu 1 3a stat\");\n+\n+\timgu_ = enumerator->search(imgu_dm);\n+\tif (!imgu_) {\n+\t\tcio2_->release();\n+\t\treturn false;\n+\t}\n+\n+\timgu_->acquire();\n+\n+\t/*\n+\t * TODO: create cameras. As of now, just create a dummy one\n+\t * to verify enumeration and matching on IPU3.\n+\t */\n+\tcamera_ = new Camera(\"IPU3 Camera\");\n+\n+\treturn true;\n+}\n+\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/ipu3/meson.build b/src/libcamera/pipeline/ipu3/meson.build\nnew file mode 100644\nindex 0000000..0ab766a\n--- /dev/null\n+++ b/src/libcamera/pipeline/ipu3/meson.build\n@@ -0,0 +1,3 @@\n+libcamera_sources += files([\n+ 'ipu3.cpp',\n+])\ndiff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\nindex 615ecd2..811c075 100644\n--- a/src/libcamera/pipeline/meson.build\n+++ b/src/libcamera/pipeline/meson.build\n@@ -1,3 +1,5 @@\n libcamera_sources += files([\n 'vimc.cpp',\n ])\n+\n+subdir('ipu3')\n","prefixes":["libcamera-devel"]}