{"id":21087,"url":"https://patchwork.libcamera.org/api/1.1/patches/21087/?format=json","web_url":"https://patchwork.libcamera.org/patch/21087/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830131904.1090330-5-mzamazal@redhat.com>","date":"2024-08-30T13:18:41","name":"[04/19] libcamera: rkisp1: Remove unused includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6007f985fea6db5770accc131abae071cffd0707","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21087/mbox/","series":[{"id":4551,"url":"https://patchwork.libcamera.org/api/1.1/series/4551/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4551","date":"2024-08-30T13:18:37","name":"Remove unused includes","version":1,"mbox":"https://patchwork.libcamera.org/series/4551/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21087/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21087/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E945C32C2\n\tfor ;\n\tFri, 30 Aug 2024 13:19:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9FE7634CC;\n\tFri, 30 Aug 2024 15:19:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B563E634CB\n\tfor ;\n\tFri, 30 Aug 2024 15:19:27 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-443-DqaK8vblOhWzCnU21GJ7Ow-1;\n\tFri, 30 Aug 2024 09:19:23 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 1AA5C1955F3B for ;\n\tFri, 30 Aug 2024 13:19:23 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D2F7219560AA; Fri, 30 Aug 2024 13:19:21 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"i6xrCkSS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725023966;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=97y4j6cbj7MpOmXAsRm2Btt19g0LOOX0e1/7evm3xAU=;\n\tb=i6xrCkSSSCWJVTskIHWsNrwyx1dca1oTeEmanFfV2INEB6lvcpRioplJb6y/Fk2iZllSl5\n\tCSQQ/xUX72q3CMUzK81mPi7Lk0oQWf6Odc4SwiiSZV7Al6EMst+V8ZHe0fzq7hE7zV5xv4\n\tFn2sVB+NB7cYUayZr0WZ3QvR5OnUcGM=","X-MC-Unique":"DqaK8vblOhWzCnU21GJ7Ow-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[PATCH 04/19] libcamera: rkisp1: Remove unused includes","Date":"Fri, 30 Aug 2024 15:18:41 +0200","Message-ID":"<20240830131904.1090330-5-mzamazal@redhat.com>","In-Reply-To":"<20240830131904.1090330-1-mzamazal@redhat.com>","References":"<20240830131904.1090330-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/rkisp1/algorithms/agc.h | 1 -\n src/ipa/rkisp1/algorithms/awb.cpp | 2 --\n src/ipa/rkisp1/algorithms/ccm.cpp | 4 ----\n src/ipa/rkisp1/algorithms/dpf.cpp | 2 --\n src/ipa/rkisp1/rkisp1.cpp | 2 --\n src/ipa/rkisp1/utils.h | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 --\n 7 files changed, 14 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex d64ff42c..aa86f2c5 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -15,7 +15,6 @@\n #include \n \n #include \"libipa/agc_mean_luminance.h\"\n-#include \"libipa/histogram.h\"\n \n #include \"algorithm.h\"\n \ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex b40f405f..a5972015 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -8,8 +8,6 @@\n #include \"awb.h\"\n \n #include \n-#include \n-#include \n \n #include \n \ndiff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex ca80112a..47a8b7e5 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -7,10 +7,6 @@\n \n #include \"ccm.h\"\n \n-#include \n-#include \n-#include \n-#include \n #include \n \n #include \ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 079cc2c3..94080b28 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -7,8 +7,6 @@\n \n #include \"dpf.h\"\n \n-#include \n-\n #include \n \n #include \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 79ae9289..55269579 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -6,8 +6,6 @@\n */\n \n #include \n-#include \n-#include \n #include \n #include \n \ndiff --git a/src/ipa/rkisp1/utils.h b/src/ipa/rkisp1/utils.h\nindex 450f2244..5f38b50b 100644\n--- a/src/ipa/rkisp1/utils.h\n+++ b/src/ipa/rkisp1/utils.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include \n-#include \n #include \n \n namespace libcamera {\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 710d9573..5ff8eb9c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -6,8 +6,6 @@\n */\n \n #include \n-#include \n-#include \n #include \n #include \n #include \n","prefixes":["04/19"]}