{"id":21085,"url":"https://patchwork.libcamera.org/api/1.1/patches/21085/?format=json","web_url":"https://patchwork.libcamera.org/patch/21085/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830131904.1090330-3-mzamazal@redhat.com>","date":"2024-08-30T13:18:39","name":"[02/19] libcamera: ipu3: Replace wrong include","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cbe3f3518bb2be002ae8612ad9146d24eaddb16f","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21085/mbox/","series":[{"id":4551,"url":"https://patchwork.libcamera.org/api/1.1/series/4551/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4551","date":"2024-08-30T13:18:37","name":"Remove unused includes","version":1,"mbox":"https://patchwork.libcamera.org/series/4551/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21085/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21085/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAFACC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 13:19:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD4966341E;\n\tFri, 30 Aug 2024 15:19:26 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F27D56345A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 15:19:22 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-135--41ksjKkN7O3OHeWWsttiA-1;\n\tFri, 30 Aug 2024 09:19:20 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 96F7B1955D48 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 13:19:19 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 41F3719560AA; Fri, 30 Aug 2024 13:19:17 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"fbFIo5K9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725023962;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=gDHVeNMFKSWnDfjkPStA5LXfRtrx/FL2tfHLlZgv4Do=;\n\tb=fbFIo5K9AS40xcakbwK0BF8MczB2V/+2/XQAA//M0dIuuyNy2MpuaFQJrkJVRo1LjK4qYJ\n\tTcDWWFh4jvGZumcim1uwPaLmE1BLhZkJ3li9kwliKe3Vz6gWE7m+SgRoui2GuBwScyeck5\n\tPKoVlteM/btMv3mhKcXQeI1Tf4ALEY0=","X-MC-Unique":"-41ksjKkN7O3OHeWWsttiA-1","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>","Subject":"[PATCH 02/19] libcamera: ipu3: Replace wrong include","Date":"Fri, 30 Aug 2024 15:18:39 +0200","Message-ID":"<20240830131904.1090330-3-mzamazal@redhat.com>","In-Reply-To":"<20240830131904.1090330-1-mzamazal@redhat.com>","References":"<20240830131904.1090330-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"v4l2_videodevice.h is not used but logging is imported through it.\nRemove the unused include and include log.h instead.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 88eb9d05..bc0526a7 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -7,12 +7,13 @@\n \n #include \"frames.h\"\n \n+#include <libcamera/base/log.h>\n+\n #include <libcamera/framebuffer.h>\n #include <libcamera/request.h>\n \n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n-#include \"libcamera/internal/v4l2_videodevice.h\"\n \n namespace libcamera {\n \n","prefixes":["02/19"]}