{"id":21081,"url":"https://patchwork.libcamera.org/api/1.1/patches/21081/?format=json","web_url":"https://patchwork.libcamera.org/patch/21081/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830125311.1702053-3-stefan.klug@ideasonboard.com>","date":"2024-08-30T12:52:59","name":"[2/3] utils: checkstye: Show issue position for python issues","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a6e6641b5226b4d0ba3e4a9442fe490322406827","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21081/mbox/","series":[{"id":4550,"url":"https://patchwork.libcamera.org/api/1.1/series/4550/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4550","date":"2024-08-30T12:52:57","name":"Python improvements to checkstyle.py","version":1,"mbox":"https://patchwork.libcamera.org/series/4550/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21081/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21081/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D033C323E\n\tfor ;\n\tFri, 30 Aug 2024 12:53:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D62E6341E;\n\tFri, 30 Aug 2024 14:53:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 898A263466\n\tfor ;\n\tFri, 30 Aug 2024 14:53:25 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:cdac:b850:c793:ea45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58FBF512;\n\tFri, 30 Aug 2024 14:52:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c7ThQK/U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725022336;\n\tbh=Uap09w+3CURzA5gEtOe1Er5VKL6HcqpeE57robYcvCk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c7ThQK/UeO/GHlCuS1zemkYW9X6to71IRgMvoy6dYeuVFSBU5SngIsaVkhztFvy2A\n\tMFC/0E8SoawqdTY2hFX+fk7Ox2GeAfgdon+xkAEpKJVnANeioz+PmSXXfmnhcxK1D8\n\tGmq9gfsXMeiKEfp79gUO/to27Nk+ix6F8oi+uA+s=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 2/3] utils: checkstye: Show issue position for python issues","Date":"Fri, 30 Aug 2024 14:52:59 +0200","Message-ID":"<20240830125311.1702053-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240830125311.1702053-1-stefan.klug@ideasonboard.com>","References":"<20240830125311.1702053-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"pycodestyle doesn't report the issue length. But it reports the\nposition. Use that as indicator with zero length. This is better than no\nindicator at all and reduces confusion when multiple issues occur on the\nsame line.\n\nSigned-off-by: Stefan Klug \n---\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex c6016f60a446..5901f1a71562 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -737,7 +737,7 @@ class Pep8Checker(StyleChecker):\n \n if line_number in line_numbers:\n line = self.__content[line_number - 1]\n- issues.append(StyleIssue(line_number, None, line, msg))\n+ issues.append(StyleIssue(line_number, [position, position + 1], line, msg))\n \n return issues\n \n","prefixes":["2/3"]}