{"id":21074,"url":"https://patchwork.libcamera.org/api/1.1/patches/21074/?format=json","web_url":"https://patchwork.libcamera.org/patch/21074/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830072554.180672-19-mzamazal@redhat.com>","date":"2024-08-30T07:25:54","name":"[v5,18/18] libcamera: software_isp: Update black level only on exposure changes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bf88930b2d7ab0014588876037abd30b2011a016","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21074/mbox/","series":[{"id":4548,"url":"https://patchwork.libcamera.org/api/1.1/series/4548/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4548","date":"2024-08-30T07:25:36","name":"Software ISP refactoring","version":5,"mbox":"https://patchwork.libcamera.org/series/4548/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21074/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21074/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 138C1C32DB\n\tfor ;\n\tFri, 30 Aug 2024 07:27:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F1BB634E9;\n\tFri, 30 Aug 2024 09:27:01 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4E126341E\n\tfor ;\n\tFri, 30 Aug 2024 09:26:56 +0200 (CEST)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-678-o-iSRPTeOR64iG27gIXTLA-1;\n\tFri, 30 Aug 2024 03:26:52 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 4DBBA19560A2; Fri, 30 Aug 2024 07:26:51 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 436F119560A3; Fri, 30 Aug 2024 07:26:48 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dVvyKtmZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725002815;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=G6Rb7ZNQHHJHzus5nxcQH64kx4ElvfE8MPFWA9uBZ+E=;\n\tb=dVvyKtmZiw3rDB18vYMR5XPmTsUYtWJ1NmBnwlCsC4PqiK63UMzp08XERaKdCJE00GBCTM\n\tZmjP82VYKFC4PWQ5tmhJ1kC8YmjuNc6jvix/itolpVY+0Nl+zs4IZBdSbu18lAb4PoTZSG\n\tah0ekKw8bBICTWw43JmOspmBmVSH0Ho=","X-MC-Unique":"o-iSRPTeOR64iG27gIXTLA-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ,\n\tLaurent Pinchart ,\n\tDaniel Scally ","Subject":"[PATCH v5 18/18] libcamera: software_isp: Update black level only on\n\texposure changes","Date":"Fri, 30 Aug 2024 09:25:54 +0200","Message-ID":"<20240830072554.180672-19-mzamazal@redhat.com>","In-Reply-To":"<20240830072554.180672-1-mzamazal@redhat.com>","References":"<20240830072554.180672-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The black level is likely to get updated, if ever, only after exposure\nor gain changes. Don't compute its possible updates if exposure and\ngain are unchanged.\n\nIt's probably not worth trying to implement something more\nsophisticated. Better to spend the effort on supporting tuning files.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/blc.cpp | 9 ++++++++-\n src/ipa/simple/algorithms/blc.h | 4 ++++\n 2 files changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex ab7e7dd9..d01c2c14 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -30,10 +30,15 @@ int BlackLevel::init(IPAContext &context,\n \n void BlackLevel::process(IPAContext &context,\n \t\t\t [[maybe_unused]] const uint32_t frame,\n-\t\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t\t IPAFrameContext &frameContext,\n \t\t\t const SwIspStats *stats,\n \t\t\t [[maybe_unused]] ControlList &metadata)\n {\n+\tif (frameContext.sensor.exposure == exposure_ &&\n+\t frameContext.sensor.gain == gain_) {\n+\t\treturn;\n+\t}\n+\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \n \t/*\n@@ -54,6 +59,8 @@ void BlackLevel::process(IPAContext &context,\n \t\tif (seen >= pixelThreshold) {\n \t\t\tcontext.activeState.black.level =\n \t\t\t\tstatic_cast(i) / SwIspStats::kYHistogramSize;\n+\t\t\texposure_ = frameContext.sensor.exposure;\n+\t\t\tgain_ = frameContext.sensor.gain;\n \t\t\tLOG(IPASoftBL, Debug)\n \t\t\t\t<< \"Auto-set black level: \"\n \t\t\t\t<< i << \"/\" << SwIspStats::kYHistogramSize\ndiff --git a/src/ipa/simple/algorithms/blc.h b/src/ipa/simple/algorithms/blc.h\nindex 2f73db52..9b9daab1 100644\n--- a/src/ipa/simple/algorithms/blc.h\n+++ b/src/ipa/simple/algorithms/blc.h\n@@ -30,6 +30,10 @@ public:\n \t\t IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n \t\t ControlList &metadata) override;\n+\n+private:\n+\tuint32_t exposure_;\n+\tdouble gain_;\n };\n \n } /* namespace ipa::soft::algorithms */\n","prefixes":["v5","18/18"]}