{"id":21009,"url":"https://patchwork.libcamera.org/api/1.1/patches/21009/?format=json","web_url":"https://patchwork.libcamera.org/patch/21009/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240826134639.1398830-1-chenghaoyang@google.com>","date":"2024-08-26T13:46:30","name":"libcamera: Make FrameBuffer status default to FrameSuccess","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f4b9934c4b6d15bd2e90a7e55b78fea0f4fd8ddc","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21009/mbox/","series":[{"id":4539,"url":"https://patchwork.libcamera.org/api/1.1/series/4539/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4539","date":"2024-08-26T13:46:30","name":"libcamera: Make FrameBuffer status default to FrameSuccess","version":1,"mbox":"https://patchwork.libcamera.org/series/4539/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21009/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21009/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C2C0BDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Aug 2024 13:46:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46E72633CF;\n\tMon, 26 Aug 2024 15:46:45 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 968646190C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 15:46:43 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-42817bee9e8so37360555e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 06:46:43 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-37311dca113sm8275039f8f.16.2024.08.26.06.46.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Aug 2024 06:46:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bI+i5Qzq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724680003; x=1725284803;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Qy1/syJBMQAhbeQO/SmX18QglTgwN6qIX+kHeKaQKlM=;\n\tb=bI+i5QzqErd7n7Q/bOt6iDZh98smSYBRduhT5UqZHizl9k/Xwg8KSMRCtkFyBk4KVG\n\tLNJjJRdAHy/XGeLBQAPDNb4W0IJQia1BhvrMsB17h/uJX+Ijy4N45TZIOE7a2duGzOuy\n\tMrXshsul9GUO94KI4rZBNAXkkaZP/TFHAnSeY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724680003; x=1725284803;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Qy1/syJBMQAhbeQO/SmX18QglTgwN6qIX+kHeKaQKlM=;\n\tb=h5UW2cHWVlphl8AXBKKi+P3O/GBEuY9JSmJYtRORoYJkBLv6i1nL/ihBAZcPXq7Bhd\n\tPEqofbBN7ycGopJbA4Tf+ZVY0mxY+KM1QzW6RP24q7J7pSs0Ue94OQPI2iSQcsrqrps5\n\tTz/1Rs726dAegRU0l600h3Uvz+3zxzKq2XOyyqUHpLViDtEGEU1LgS5B6d8PQrffK/MM\n\teJrVcr+Bk8OjSYoeC1VaYFyx3hn3MQ54zTRB+xkdHH+WQdo+fpuVq9UHCqjskMR7Bwpp\n\tEaTgM/D6nVEwhaheTjK8BZ4jgOPtO2UTQsAwe7NyPlp28zcTygvypGpx5lNiYdr0c3Lm\n\tJ5Sw==","X-Gm-Message-State":"AOJu0Yx7RYeT1VnBW6+nS4y8/uY0ll5KLZPAKOWO6aDZOonvRRw3zcRh\n\tn6vX3M7zz57EzKFrvb1VZ1k1s5BVv932ivfcA/knLGSFpzUnriE9cBoDwSDXUnQrB7Cx8mdZI4/\n\t/hWdU","X-Google-Smtp-Source":"AGHT+IHg9NTpnbyx4alVuEX2rRiS7YX8QqRXYmnklgijZLUchLQpmi1mzdtU7MztuwxBBxHkK2zEhA==","X-Received":"by 2002:a05:600c:3b94:b0:429:e6bb:a436 with SMTP id\n\t5b1f17b1804b1-42acd55654fmr74824305e9.9.1724680002679; \n\tMon, 26 Aug 2024 06:46:42 -0700 (PDT)","From":"Harvey Yang <chenghaoyang@chromium.org>","X-Google-Original-From":"Harvey Yang <chenghaoyang@google.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Han-Lin Chen <hanlinchen@chromium.org>","Subject":"[PATCH] libcamera: Make FrameBuffer status default to FrameSuccess","Date":"Mon, 26 Aug 2024 13:46:30 +0000","Message-ID":"<20240826134639.1398830-1-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.295.g3b9ea8a38a-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"From: Han-Lin Chen <hanlinchen@chromium.org>\n\nThere seems to be an assumption that a FrameBuffer is success unless\nthe pipeline handler canceled the frame, or there is a failure\nprocessing the FrameBuffer.\n\nMake the assumption specific.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n include/libcamera/framebuffer.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 5ae2270b3..71202a1d2 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -33,7 +33,7 @@ struct FrameMetadata {\n \t\tunsigned int bytesused;\n \t};\n \n-\tStatus status;\n+\tStatus status = FrameSuccess;\n \tunsigned int sequence;\n \tuint64_t timestamp;\n \n","prefixes":[]}