{"id":20999,"url":"https://patchwork.libcamera.org/api/1.1/patches/20999/?format=json","web_url":"https://patchwork.libcamera.org/patch/20999/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240823131148.2449434-2-chenghaoyang@google.com>","date":"2024-08-23T13:07:33","name":"[v1,1/3] libcamera: Add rectangle two-point constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cfe6a0dd145262d50f90e4f5336fca79d7a77d65","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20999/mbox/","series":[{"id":4535,"url":"https://patchwork.libcamera.org/api/1.1/series/4535/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4535","date":"2024-08-23T13:07:32","name":"Add Face Detection Controls","version":1,"mbox":"https://patchwork.libcamera.org/series/4535/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20999/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20999/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87F2EC323E\n\tfor ;\n\tFri, 23 Aug 2024 13:11:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD9D5633D5;\n\tFri, 23 Aug 2024 15:11:55 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E2B5633CB\n\tfor ;\n\tFri, 23 Aug 2024 15:11:51 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-4281c164408so14729295e9.1\n\tfor ;\n\tFri, 23 Aug 2024 06:11:51 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3730810ffb9sm4185000f8f.7.2024.08.23.06.11.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Aug 2024 06:11:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LGvp0TTp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724418711; x=1725023511;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=v9S+dT+RxEXLDnq2Dp9ErqErW7LwS5ZxIeDvscZGsxY=;\n\tb=LGvp0TTpZ74IuFT0ScsJ+UJlxEv0i1320iM3Dio93AZO6qGt+lzVW8RE4k02gA/mA1\n\tWqvK4idQHE98aWLoNabJcWkp8ozWMUjq7L9qDB2LoXzXN4sq5S3yH1zrXncX4JTQ1O4E\n\tJbpm43jg8vOw1y9YdWZdbuQBUGSVKznJ0q5bk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724418711; x=1725023511;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=v9S+dT+RxEXLDnq2Dp9ErqErW7LwS5ZxIeDvscZGsxY=;\n\tb=ERTF/m9OqBu35YHOTW90RUIATIniIpuNndnrhQ7sxUmJ9KMuYVwBH2VERuwTrciwHc\n\tvvJHeldfEGHDzyUwI9FsGeGfZWXE/KhXwf1wkBdCQxz7+roDfeJ07MXCfXUs6beUZv7N\n\t9lClouqyWesgQZfbNqyYsxqqMdv4+09VtwItyPURg8uVUWdvlOO/sj3ZSgZw8G3SjYTp\n\twGT/2z/9Thl6vovecSd/3DmnLEgwJ9Ds0y3BFfyhZwKfXhGcANbrqpKOgfQpisY/rH7Y\n\t5dp2a+Op8mGWZtITfdtlZv0AmR+wRygpxz3JWJNNZxjdnP6jT6MdDLk1eqtd/aEGmJp1\n\tUNxA==","X-Gm-Message-State":"AOJu0YwhtKVnHlSc+ZcIFq98FZTVKzmVrNmYvwiZWsIyIOP7pELhiypB\n\tzr2kjshXGN4SLQAbRoDADxhlz9G7ts8A/b7R+/SZsh4DVOGoZPsiB8YcbsxHj+nrqOFRmdARzcj\n\tNhRTf","X-Google-Smtp-Source":"AGHT+IElGzIrsoknnOi+u0wBQ+VkgKyTJufkGlbv0/IPfz74XIHiwb6Agx6yRpv7V4taVdKVb0kjig==","X-Received":"by 2002:a05:600c:4512:b0:427:fa39:b0a1 with SMTP id\n\t5b1f17b1804b1-42acc9fee00mr12802495e9.36.1724418710497; \n\tFri, 23 Aug 2024 06:11:50 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Yudhistira Erlandinata ,\n\tHarvey Yang ","Subject":"[PATCH v1 1/3] libcamera: Add rectangle two-point constructor","Date":"Fri, 23 Aug 2024 13:07:33 +0000","Message-ID":"<20240823131148.2449434-2-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.295.g3b9ea8a38a-goog","In-Reply-To":"<20240823131148.2449434-1-chenghaoyang@google.com>","References":"<20240823131148.2449434-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd a Rectangle constructor that accepts two points:\ntopLeft and bottomRight.\n\nBUG=b:308714092\nTEST=emerge-geralt libcamera-mtkisp7\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \n---\n include/libcamera/geometry.h | 10 ++++++++++\n src/libcamera/geometry.cpp | 7 +++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 3e6f0f5d7..4566c95b3 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -8,6 +8,8 @@\n #pragma once\n \n #include \n+#include \n+#include \n #include \n #include \n \n@@ -262,6 +264,14 @@ public:\n \t{\n \t}\n \n+\tconstexpr Rectangle(const Point &topLeft, const Point &bottomRight)\n+\t\t: x(topLeft.x), y(topLeft.y),\n+\t\t width(bottomRight.x - x),\n+\t\t height(bottomRight.y - y)\n+\t{\n+\t\tassert(bottomRight.x >= x && bottomRight.y >= y);\n+\t}\n+\n \tint x;\n \tint y;\n \tunsigned int width;\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 000151364..008b8ea04 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -629,6 +629,13 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n * \\param[in] size The desired Rectangle size\n */\n \n+/**\n+ * \\fn Rectangle::Rectangle(const Point &topLeft, const Point &bottomRight)\n+ * \\brief Construct a Rectangle with the two given points.\n+ * \\param[in] topLeft The top-left corner\n+ * \\param[in] bottomRight The bottom-right corner\n+ */\n+\n /**\n * \\var Rectangle::x\n * \\brief The horizontal coordinate of the rectangle's top-left corner\n","prefixes":["v1","1/3"]}