{"id":20975,"url":"https://patchwork.libcamera.org/api/1.1/patches/20975/?format=json","web_url":"https://patchwork.libcamera.org/patch/20975/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240820172202.526547-9-chenghaoyang@google.com>","date":"2024-08-20T16:23:39","name":"[v9,8/8] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5f98528d63df8d5fec95e0c9da3bdff582bbd04e","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20975/mbox/","series":[{"id":4529,"url":"https://patchwork.libcamera.org/api/1.1/series/4529/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4529","date":"2024-08-20T16:23:31","name":"Add VirtualPipelineHandler","version":9,"mbox":"https://patchwork.libcamera.org/series/4529/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20975/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20975/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 727D7C323E\n\tfor ;\n\tTue, 20 Aug 2024 17:22:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3046633FA;\n\tTue, 20 Aug 2024 19:22:34 +0200 (CEST)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 809F7633D5\n\tfor ;\n\tTue, 20 Aug 2024 19:22:21 +0200 (CEST)","by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-428243f928cso46685215e9.3\n\tfor ;\n\tTue, 20 Aug 2024 10:22:21 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42ab6e90db5sm30328575e9.0.2024.08.20.10.22.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Aug 2024 10:22:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bHWZZm6o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724174541; x=1724779341;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TsnaMW9RnciKwlBvDg1jm/k8oS0941yZ3v5QaArfrqE=;\n\tb=bHWZZm6o/oN6PcmIrTXRZDiB9qwshSK46yPBcW1XqkDwP6mNr2FejLSb56RJkBCU9I\n\tNLIS/EqtODWUCpfBeVqE3xX3G6/W88sAwv5h1XQxT17dFrvxBM4Q/5W2keJqhDdzXVeX\n\t6I1pAQ48WfmV/8Gt+hgKHB0QDpm0AqjjA7+rA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724174541; x=1724779341;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TsnaMW9RnciKwlBvDg1jm/k8oS0941yZ3v5QaArfrqE=;\n\tb=BUwiYBVWUDpctfmeSoKfuWplOTIe3QMHQLzF/sWUs8nygvjCYshRR7I6F7f8Ca1hYY\n\tclG7xESyWCA4zNZPto0+xIg11XER8UMgK5MR1yMzbx+qduT2DQFOWFnotU9p8OFOvq0B\n\t2DB0F3Z7wLwbwUCmN0QX1/qN8ASOhN5DF4VM+vOTGZWPbetKgD5kssgeWEM2wI55vzFm\n\thUKfk3HsaMDbs86UdcgaERRVlCOa+ZaIKEBC2bJ3rUq0jhQoih1r0inquL1rKRKs1P8B\n\tUY3tlPCrrC+3aZFvTLJPOSUrfNnu2csv/93o9mILTPcprjXU+IOf1eZDAjP9P/ijojDy\n\tG9GQ==","X-Gm-Message-State":"AOJu0YzutWQgIIyV+0wcBvpVZwEm1ug8fpf2w9KVYlqAabT2YPUd9jbP\n\tsZnZNlhqkoRDOpa+Y2EOwjMxBioTLtvCYlBFBCsbwfxKsHmvG/E5RKwooRxtjAZzXaEaDAuzm2Y\n\t1h33ifFI=","X-Google-Smtp-Source":"AGHT+IGUQ126/tskHXTdmzT8XnEC3ItBHDOwWkqMxcNYRe0QlAQgMnJdRJg2T+Eqq4/g+hJ9JZXxSw==","X-Received":"by 2002:a05:600c:46c4:b0:428:16a0:1c3d with SMTP id\n\t5b1f17b1804b1-42abd2282c3mr558915e9.19.1724174540789; \n\tTue, 20 Aug 2024 10:22:20 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHarvey Yang ,\n\tMilan Zamazal ","Subject":"[PATCH v9 8/8] libcamera: software_isp: Refactor SoftwareIsp to use\n\tDmaBufAllocator::exportBuffers","Date":"Tue, 20 Aug 2024 16:23:39 +0000","Message-ID":"<20240820172202.526547-9-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.184.g6999bdac58-goog","In-Reply-To":"<20240820172202.526547-1-chenghaoyang@google.com>","References":"<20240820172202.526547-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As the helper function DmaBufAllocator::exportBuffers is added, we can\navoid some code duplication in SoftwareIsp as well.\n\nSigned-off-by: Harvey Yang \nReviewed-by: Milan Zamazal \n---\n src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex c8748d888..35077feb2 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -256,25 +256,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n \tif (stream == nullptr)\n \t\treturn -EINVAL;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst std::string name = \"frame-\" + std::to_string(i);\n-\t\tconst size_t frameSize = debayer_->frameSize();\n-\n-\t\tFrameBuffer::Plane outPlane;\n-\t\toutPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n-\t\tif (!outPlane.fd.isValid()) {\n-\t\t\tLOG(SoftwareIsp, Error)\n-\t\t\t\t<< \"failed to allocate a dma_buf\";\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\toutPlane.offset = 0;\n-\t\toutPlane.length = frameSize;\n-\n-\t\tstd::vector planes{ outPlane };\n-\t\tbuffers->emplace_back(std::make_unique(std::move(planes)));\n-\t}\n-\n-\treturn count;\n+\treturn dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n }\n \n /**\n","prefixes":["v9","8/8"]}