{"id":20947,"url":"https://patchwork.libcamera.org/api/1.1/patches/20947/?format=json","web_url":"https://patchwork.libcamera.org/patch/20947/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","date":"2024-08-15T21:09:25","name":"[3/3] libcamera: pipeline: simple: Use MediaLink string helper","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d3d3eea4c73fe6f32464a1b31e0202af22bc267c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20947/mbox/","series":[{"id":4525,"url":"https://patchwork.libcamera.org/api/1.1/series/4525/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4525","date":"2024-08-15T21:09:22","name":"MediaLink: Provide a string representation","version":1,"mbox":"https://patchwork.libcamera.org/series/4525/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20947/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20947/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C867C32D6\n\tfor ;\n\tThu, 15 Aug 2024 21:09:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5998D633C6;\n\tThu, 15 Aug 2024 23:09:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CBE4633B3\n\tfor ;\n\tThu, 15 Aug 2024 23:09:29 +0200 (CEST)","from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C34A6827;\n\tThu, 15 Aug 2024 23:08:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l4cm8A0y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723756110;\n\tbh=YlsSyq+a+Tqs30qmAANM6uSIFDYOlYP5mKzfhlV1P98=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l4cm8A0yund3HrKs/pyWJeFPMnsFu4dyT5On1xn/lUMdW+Kp+31xgC3XkNIks1VLH\n\tnmkRQsZhoVOBIhFt/eMkTmn85DlGQLEE8/0Sogf30kn+L7yqYYql7fJEaUTIwdE8NM\n\tRD8+u1LJqRrma/JZR6Y3YFAV1Etlg8EbFOR9E2EQ=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH 3/3] libcamera: pipeline: simple: Use MediaLink string helper","Date":"Thu, 15 Aug 2024 22:09:25 +0100","Message-Id":"<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the open-coded implementation of a link representation\nwith the operator<< overload string representation to simplify\nthe code and unify appearance of reporting MediaLinks.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 1e7ec7d97255..2d205e9925ef 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n \t\t}\n \n \t\tLOG(SimplePipeline, Debug)\n-\t\t\t<< \"Link '\" << source->entity()->name()\n-\t\t\t<< \"':\" << source->index()\n-\t\t\t<< \" -> '\" << sink->entity()->name()\n-\t\t\t<< \"':\" << sink->index()\n-\t\t\t<< \" configured with format \" << *format;\n+\t\t\t<< \"Link \" << *link << \": configured with format \"\n+\t\t\t<< *format;\n \t}\n \n \treturn 0;\n","prefixes":["3/3"]}