{"id":20925,"url":"https://patchwork.libcamera.org/api/1.1/patches/20925/?format=json","web_url":"https://patchwork.libcamera.org/patch/20925/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240815081622.174210-13-mzamazal@redhat.com>","date":"2024-08-15T08:16:16","name":"[v4,12/18] libcamera: software_isp: Call Algorithm::process","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"10c08d184e3c57ce307d826163eb8311b880a778","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20925/mbox/","series":[{"id":4520,"url":"https://patchwork.libcamera.org/api/1.1/series/4520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4520","date":"2024-08-15T08:16:04","name":"Software ISP refactoring","version":4,"mbox":"https://patchwork.libcamera.org/series/4520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20925/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20925/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D060DC32A9\n\tfor ;\n\tThu, 15 Aug 2024 08:17:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68D73633C0;\n\tThu, 15 Aug 2024 10:17:27 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D452A633C8\n\tfor ;\n\tThu, 15 Aug 2024 10:17:24 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-589-ukDjdYymMben8ptYRlmy2Q-1;\n\tThu, 15 Aug 2024 04:17:19 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 1F6B91954B1D; Thu, 15 Aug 2024 08:17:18 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.128])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D1B7119560A3; Thu, 15 Aug 2024 08:17:15 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"O0gfkMNH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723709843;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=R6pipysZ/qYOzyonkafacIN3VlyHa05TRmcXWXBfMSU=;\n\tb=O0gfkMNHSc5WHZFIJQ5vFD3sxaTc4LiHMJ7NhD3i3Q88pSjediKnceZ6lM0R+20T8lAjsy\n\tto7DOPLsQGfTlAxsRxvEuwe6ZQj51JqNuAD/Ubfocyulm0bQkLWsjmSquCXsvOiG6aKsuZ\n\tQbQSkUN/W8iWvcqE3ImpeUjAZTGDgr4=","X-MC-Unique":"ukDjdYymMben8ptYRlmy2Q-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ,\n\tLaurent Pinchart ,\n\tDaniel Scally ","Subject":"[PATCH v4 12/18] libcamera: software_isp: Call Algorithm::process","Date":"Thu, 15 Aug 2024 10:16:16 +0200","Message-ID":"<20240815081622.174210-13-mzamazal@redhat.com>","In-Reply-To":"<20240815081622.174210-1-mzamazal@redhat.com>","References":"<20240815081622.174210-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch adds Algorithm::process call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nAs software ISP currently doesn't produce any metadata, a dummy and\nunused metadata instance is created to satisfy Algorithm::process API.\nThis should be changed in future.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nReviewed-by: Daniel Scally \n---\n src/ipa/simple/soft_simple.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex d52242be..4b9201dc 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -287,10 +287,21 @@ void IPASoftSimple::prepare(const uint32_t frame)\n \t\talgo->prepare(context_, frame, frameContext, params_);\n }\n \n-void IPASoftSimple::processStats([[maybe_unused]] const uint32_t frame,\n+void IPASoftSimple::processStats(const uint32_t frame,\n \t\t\t\t [[maybe_unused]] const uint32_t bufferId,\n \t\t\t\t const ControlList &sensorControls)\n {\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\t/*\n+\t * Software ISP currently does not produce any metadata. Use an empty\n+\t * ControlList for now.\n+\t *\n+\t * \\todo Implement proper metadata handling\n+\t */\n+\tControlList metadata(controls::controls);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->process(context_, frame, frameContext, stats_, metadata);\n+\n \tSwIspStats::Histogram histogram = stats_->yHistogram;\n \tif (ignoreUpdates_ > 0)\n \t\tblackLevel_.update(histogram);\n","prefixes":["v4","12/18"]}