{"id":20872,"url":"https://patchwork.libcamera.org/api/1.1/patches/20872/?format=json","web_url":"https://patchwork.libcamera.org/patch/20872/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>","date":"2024-08-10T01:17:46","name":"libcamera: Fix header grouping","commit_ref":"43632663229d7cb4396ca1cd14cc87a0fd2a9602","pull_url":null,"state":"accepted","archived":false,"hash":"74903d56ee78bb116fde357b584ff573286f5585","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20872/mbox/","series":[{"id":4509,"url":"https://patchwork.libcamera.org/api/1.1/series/4509/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4509","date":"2024-08-10T01:17:46","name":"libcamera: Fix header grouping","version":1,"mbox":"https://patchwork.libcamera.org/series/4509/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20872/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20872/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6E54C323E\n\tfor ;\n\tSat, 10 Aug 2024 01:18:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B88EE633B3;\n\tSat, 10 Aug 2024 03:18:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E554261946\n\tfor ;\n\tSat, 10 Aug 2024 03:18:10 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EB4345B\n\tfor ;\n\tSat, 10 Aug 2024 03:17:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HIngrliW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723252636;\n\tbh=hoFnrCtvsCCOAT6weTtf+VSiEtF5EG4wlPEZ4oKAF0c=;\n\th=From:To:Subject:Date:From;\n\tb=HIngrliWMGKNBijdScpiPnc4uHBuEG7AevE2nDx0maJiPmFhKCzo1bDrcPpbn1uHZ\n\trvnv05YV8hnp7aId8hntWwlC8JE6AoMoi9huV9fp1JAU3mFXSo0Ip8mQC0yZZxjXI/\n\t9Ac4n8XshpzYuVKxbOWeA03JJfSnitHH+Do96NEo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] libcamera: Fix header grouping","Date":"Sat, 10 Aug 2024 04:17:46 +0300","Message-ID":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The libcamera coding style groups the C and C++ standard library headers\nin a single group. Fix the few offenders in the source tree.\n\nWhile at it, add a missing blank line between header groups in a\nseparate location.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/base/file.h | 5 ++---\n include/libcamera/ipa/ipa_interface.h | 3 +--\n src/gstreamer/gstlibcamerapool.cpp | 1 +\n src/ipa/libipa/camera_sensor_helper.h | 3 +--\n 4 files changed, 5 insertions(+), 7 deletions(-)\n\n\nbase-commit: 62760bd2605a83e663b9003244ff42f8946f8955","diff":"diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\nindex 192668abeff1..6d3f106d5900 100644\n--- a/include/libcamera/base/file.h\n+++ b/include/libcamera/base/file.h\n@@ -7,11 +7,10 @@\n \n #pragma once\n \n-#include \n-#include \n-\n #include \n+#include \n #include \n+#include \n \n #include \n \ndiff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 53cf5377fcc6..7c835e984442 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -7,10 +7,9 @@\n \n #pragma once\n \n+#include \n #include \n #include \n-\n-#include \n #include \n \n #include \ndiff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\nindex 0b1a5689eadb..9cd7eccb5af3 100644\n--- a/src/gstreamer/gstlibcamerapool.cpp\n+++ b/src/gstreamer/gstlibcamerapool.cpp\n@@ -9,6 +9,7 @@\n #include \"gstlibcamerapool.h\"\n \n #include \n+\n #include \n \n #include \"gstlibcamera-utils.h\"\ndiff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex ac276e27f523..758682058b9c 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -7,10 +7,9 @@\n \n #pragma once\n \n-#include \n-\n #include \n #include \n+#include \n #include \n #include \n \n","prefixes":[]}