{"id":2086,"url":"https://patchwork.libcamera.org/api/1.1/patches/2086/?format=json","web_url":"https://patchwork.libcamera.org/patch/2086/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191003174941.1296988-5-niklas.soderlund@ragnatech.se>","date":"2019-10-03T17:49:34","name":"[libcamera-devel,v4,04/11] libcamera: request: Add meta data information","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4177337542c4d390c8be5d947c5fb8e5614df34f","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2086/mbox/","series":[{"id":516,"url":"https://patchwork.libcamera.org/api/1.1/series/516/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=516","date":"2019-10-03T17:49:31","name":"libcamera: ipa: Add basic IPA support","version":4,"mbox":"https://patchwork.libcamera.org/series/516/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2086/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2086/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 772EB61915\n\tfor ;\n\tThu, 3 Oct 2019 19:50:38 +0200 (CEST)","from bismarck.berto.se (unknown [84.172.88.101])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 320eb6db-e606-11e9-837a-0050569116f7;\n\tThu, 03 Oct 2019 19:49:49 +0200 (CEST)"],"X-Halon-ID":"320eb6db-e606-11e9-837a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 3 Oct 2019 19:49:34 +0200","Message-Id":"<20191003174941.1296988-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191003174941.1296988-1-niklas.soderlund@ragnatech.se>","References":"<20191003174941.1296988-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/11] libcamera: request: Add meta\n\tdata information","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 17:50:38 -0000"},"content":"A new ControlList container is needed to hold meta data coming out of\nthe IPA. The list of supported controls in this list is expected to grow\nand for now do not add a validator for the list.\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/request.h | 2 ++\n src/libcamera/request.cpp | 12 ++++++++++++\n 2 files changed, 14 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex e3db5243aaf3cf30..d3435d134c560f44 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -37,6 +37,7 @@ public:\n \t~Request();\n \n \tControlList &controls() { return *controls_; }\n+\tControlList &metaData() { return *metaData_; }\n \tconst std::map &buffers() const { return bufferMap_; }\n \tint addBuffer(std::unique_ptr buffer);\n \tBuffer *findBuffer(Stream *stream) const;\n@@ -58,6 +59,7 @@ private:\n \tCamera *camera_;\n \tCameraControlValidator *validator_;\n \tControlList *controls_;\n+\tControlList *metaData_;\n \tstd::map bufferMap_;\n \tstd::unordered_set pending_;\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 19f6d0b9a0aeb03c..1e1418a9b57393b3 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -65,6 +65,11 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t */\n \tvalidator_ = new CameraControlValidator(camera);\n \tcontrols_ = new ControlList(validator_);\n+\n+\t/**\n+\t * \\todo: Add a validator for meta data controls.\n+\t */\n+\tmetaData_ = new ControlList(nullptr);\n }\n \n Request::~Request()\n@@ -74,6 +79,7 @@ Request::~Request()\n \t\tdelete buffer;\n \t}\n \n+\tdelete metaData_;\n \tdelete controls_;\n \tdelete validator_;\n }\n@@ -161,6 +167,12 @@ Buffer *Request::findBuffer(Stream *stream) const\n \treturn it->second;\n }\n \n+/**\n+ * \\fn Request::metaData()\n+ * \\brief Retrieve the request's meta data\n+ * \\return The meta data associated with the request\n+ */\n+\n /**\n * \\fn Request::cookie()\n * \\brief Retrieve the cookie set when the request was created\n","prefixes":["libcamera-devel","v4","04/11"]}