{"id":20716,"url":"https://patchwork.libcamera.org/api/1.1/patches/20716/?format=json","web_url":"https://patchwork.libcamera.org/patch/20716/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>","date":"2024-07-29T17:55:59","name":"apps: qcam: Disable -Wextra-semi","commit_ref":"d5cbf69a7feb39af5b767f2d000f9aead80d7563","pull_url":null,"state":"accepted","archived":false,"hash":"886981c651c53303f3e4123fa0d1061717aefcd7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20716/mbox/","series":[{"id":4464,"url":"https://patchwork.libcamera.org/api/1.1/series/4464/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4464","date":"2024-07-29T17:55:59","name":"apps: qcam: Disable -Wextra-semi","version":1,"mbox":"https://patchwork.libcamera.org/series/4464/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20716/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20716/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CAFBC323E\n\tfor ;\n\tMon, 29 Jul 2024 17:56:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C998F63369;\n\tMon, 29 Jul 2024 19:56:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3ED0661984\n\tfor ;\n\tMon, 29 Jul 2024 19:56:21 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BE5418D\n\tfor ;\n\tMon, 29 Jul 2024 19:55:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n11mIwOv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722275734;\n\tbh=FsuncHydiRgu4jFlExiVfo0qrWBlqTdKsZuBNqZKXYA=;\n\th=From:To:Subject:Date:From;\n\tb=n11mIwOvXKtmpchsJ+QRPQ1l/LthG5QXiA7Ep1J5Yr+Jumt6YSNQ1nXay2tc7RhDv\n\t7jB5NAVYbnRZBAcWRB/3br0cAPNA4dchiIrUwC2WkeVNaG7Etsc28Bg1PuHQWVqWL5\n\tc3rHxunzDUAfOlW37rgHyXUpAc5R6UWbeC48iGJs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] apps: qcam: Disable -Wextra-semi","Date":"Mon, 29 Jul 2024 20:55:59 +0300","Message-ID":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Qt 6 qkeysequence.h header has an extra semicolon. This causes a\nbuild failure with clang:\n\n/usr/include/qt6/QtGui/qkeysequence.h:139:26: error: extra ';' after member function definition [-Werror,-Wextra-semi]\n 139 | Q_ENUM(SequenceMatch);\n | ^\n\nWe can't fix the issue, so ignore the warning in qcam.\n\nSigned-off-by: Laurent Pinchart \n---\n src/apps/qcam/meson.build | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\n\nbase-commit: c9152bad5ce905f5a31dbd05b40195f02c0cc2a9","diff":"diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\nindex c7fcfbeb6f61..f7c140643373 100644\n--- a/src/apps/qcam/meson.build\n+++ b/src/apps/qcam/meson.build\n@@ -36,7 +36,11 @@ qcam_resources = files([\n 'assets/shader/shaders.qrc',\n ])\n \n-qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n+qt6_cpp_args = [\n+ apps_cpp_args,\n+ '-DQT_NO_KEYWORDS',\n+ '-Wno-extra-semi',\n+]\n \n resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n qresources : qcam_resources,\n","prefixes":[]}