{"id":20697,"url":"https://patchwork.libcamera.org/api/1.1/patches/20697/?format=json","web_url":"https://patchwork.libcamera.org/patch/20697/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240723141814.76823-1-dse@thaumatec.com>","date":"2024-07-23T14:17:58","name":"[v1] libipa: camera_sensor_helper: Add OV5675 black level","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b8b4d8f2d81cf12472736f9a47c53a24f7962eb4","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/1.1/people/126/?format=json","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20697/mbox/","series":[{"id":4457,"url":"https://patchwork.libcamera.org/api/1.1/series/4457/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4457","date":"2024-07-23T14:17:58","name":"[v1] libipa: camera_sensor_helper: Add OV5675 black level","version":1,"mbox":"https://patchwork.libcamera.org/series/4457/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20697/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20697/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7BB8C323E\n\tfor ;\n\tTue, 23 Jul 2024 14:18:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 960D16336F;\n\tTue, 23 Jul 2024 16:18:29 +0200 (CEST)","from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com\n\t[IPv6:2a00:1450:4864:20::52c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E5BC619A1\n\tfor ;\n\tTue, 23 Jul 2024 16:18:27 +0200 (CEST)","by mail-ed1-x52c.google.com with SMTP id\n\t4fb4d7f45d1cf-59589a9be92so5216083a12.2\n\tfor ;\n\tTue, 23 Jul 2024 07:18:27 -0700 (PDT)","from localhost.localdomain ([91.90.172.13])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-5a30c2f8a5fsm7537595a12.62.2024.07.23.07.18.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Jul 2024 07:18:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=thaumatec-com.20230601.gappssmtp.com\n\theader.i=@thaumatec-com.20230601.gappssmtp.com\n\theader.b=\"UHvvMEoq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1721744307;\n\tx=1722349107; darn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ckne10Pw7G3MjSIZUsCyjric8DWTB7cc8Hyvg8KjZ4g=;\n\tb=UHvvMEoqwv80bPVCqVu0+U+HwKKfzHGH58vviSVeLPRO+p/0fJrg8S0H0ax3h12Ds+\n\tVxJlNJkbXWL3U2XSf1KIXbcNOywHCnAOoNy7RJD/BILh6OGebKm8UcxKQW5WrLAIssEE\n\tfGaEmRCGWtJiqbSULyy2NwY2pocPPyyeHmNYYm+3gfsP85K7suEBrxr58EuRZIo26FmC\n\tTUVdjYw8TfqctUDTljd+0U5wSP21q8DE3fwIlJyjWo1QOaLkya/yvhFa9doo5GwtM2OM\n\tYx0V6RX5+gMLoX09dLbdhNEb5YE5E9LCiFXPdEcfYXsSLhzdk+gkWfpQVuJRK3XpYR24\n\twxCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1721744307; x=1722349107;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ckne10Pw7G3MjSIZUsCyjric8DWTB7cc8Hyvg8KjZ4g=;\n\tb=cyOXb97eFLYfOLHlprhEl3TcgUjMZKskiH2nwQMlHL39ZvG6VhWHVMgSyal9Df06lt\n\tw3srxh4SyEvt8nxPHljca0cb6CBTUDz2gx4TsMPtO1ybKoNZGaOcMPTiEykn4+823OYa\n\tSLhxShDZHhUT22aeG6qO0Sl3Q7Qg/ikVH+8wmQy3dXtTqVCDccMuhb+UY46tFqGDoZN2\n\tImkS6202cD8xpuTO+u1dPeScpD4wY7ivK2CiPdIWdBH4sOSfLBOW1vZ8KGWaAbKYml27\n\tvviJpICzUa9qviIHzGqOYhNpYuAyGoNTKzy+PzPnQ3nGgTDTvboJqCdAAfJEjczEJNkN\n\t3Nrw==","X-Gm-Message-State":"AOJu0YxHQAPM/33BRByv5SX7FeHzSiysH9jDpeU5g2RzGyqrgjKI5HoA\n\tXHOc2s4kFm0Mqwzuzi1sU7sl0A9fR8SKK1RFamLYIwGks/uJUnLGG9jT46Yz6Kvnf/nFa7o15cX\n\tL","X-Google-Smtp-Source":"AGHT+IFhXd3dxyxkePAK1E3M/+k37CsbYVJPjB6lAw7xnZyANFCmMYM5bKee2jwLh7EDeXoJi2hdFg==","X-Received":"by 2002:a50:c31d:0:b0:57d:357d:9909 with SMTP id\n\t4fb4d7f45d1cf-5a943b098cdmr1875170a12.33.1721744306826; \n\tTue, 23 Jul 2024 07:18:26 -0700 (PDT)","From":"Daniel Semkowicz ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Semkowicz ","Subject":"[PATCH v1] libipa: camera_sensor_helper: Add OV5675 black level","Date":"Tue, 23 Jul 2024 16:17:58 +0200","Message-ID":"<20240723141814.76823-1-dse@thaumatec.com>","X-Mailer":"git-send-email 2.45.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add black level value for OV5675 camera.\nAccording to datasheet, default value is 0x10, 10 bits width.\n\nSigned-off-by: Daniel Semkowicz \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex a1339c83..79608c00 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -601,6 +601,8 @@ class CameraSensorHelperOv5675 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv5675()\n \t{\n+\t\t/* From datasheet: 0x10 at 10bits. */\n+\t\tblackLevel_ = 1024;\n \t\tgainType_ = AnalogueGainLinear;\n \t\tgainConstants_.linear = { 1, 0, 0, 128 };\n \t}\n","prefixes":["v1"]}