{"id":20620,"url":"https://patchwork.libcamera.org/api/1.1/patches/20620/?format=json","web_url":"https://patchwork.libcamera.org/patch/20620/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240709143913.3276983-4-dan.scally@ideasonboard.com>","date":"2024-07-09T14:39:03","name":"[v4,03/13] libcamera: mali-c55: Init camera properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1aca73ed991770979887e9913c105c729c720980","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20620/mbox/","series":[{"id":4448,"url":"https://patchwork.libcamera.org/api/1.1/series/4448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4448","date":"2024-07-09T14:39:00","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/4448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20620/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20620/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0D13BDB1C\n\tfor ;\n\tTue, 9 Jul 2024 14:39:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D075763374;\n\tTue, 9 Jul 2024 16:39:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B5AC6336D\n\tfor ;\n\tTue, 9 Jul 2024 16:39:20 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BCAD13D7;\n\tTue, 9 Jul 2024 16:38:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"drLbg3x+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720535928;\n\tbh=MIe+6qUxwUjckLd+0Baz5RY09JdELA6KYgrUDWYzquA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=drLbg3x+8/8368azsW/1WVA0NmopZZ5zLfrKPd0dUpLDP52xBZm9ruy2h+ZHVMwjx\n\tz4wZNP+JLL3CE4lKzDySqE8tJ1fmagVX/eNYbLalopoPZgpkE99e4qS18heU+B1CkK\n\tQmX44IHXkGuqT1QJr1McbhYwR8+MLj4fUDW7SRVI=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tUmang Jain ,\n\tKieran Bingham ,\n\tJacopo Mondi ","Subject":"[PATCH v4 03/13] libcamera: mali-c55: Init camera properties","Date":"Tue, 9 Jul 2024 15:39:03 +0100","Message-Id":"<20240709143913.3276983-4-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","References":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialise the camera properties using the CameraSensor properties.\n\nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex d1ae1a61..bffd842c 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties and controls. */\n+\t\tdata->properties_ = data->sensor_->properties();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n \t}\n","prefixes":["v4","03/13"]}