{"id":20619,"url":"https://patchwork.libcamera.org/api/1.1/patches/20619/?format=json","web_url":"https://patchwork.libcamera.org/patch/20619/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240709143913.3276983-3-dan.scally@ideasonboard.com>","date":"2024-07-09T14:39:02","name":"[v4,02/13] libcamera: mali-c55: Limit ISP input size","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d7958e700bef2223929935264ca7d59d4827908f","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20619/mbox/","series":[{"id":4448,"url":"https://patchwork.libcamera.org/api/1.1/series/4448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4448","date":"2024-07-09T14:39:00","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/4448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20619/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20619/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B365BDB1C\n\tfor ;\n\tTue, 9 Jul 2024 14:39:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB98C63382;\n\tTue, 9 Jul 2024 16:39:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46F8A62C95\n\tfor ;\n\tTue, 9 Jul 2024 16:39:20 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA0731894;\n\tTue, 9 Jul 2024 16:38:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"huuTBniH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720535927;\n\tbh=l7e6nx5pOwro+KRDgIiXF5yhuQcefoeJiIVM5rQrKnc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=huuTBniHncLibujjCw/Of6xaW61Ltpzn79aNnjwBbudnfVFnZyd3jmCnVussgmruL\n\tvsmpT8UKGIcG+9bNHacJlPZXCnm4SlsKRyrejZzxAufMXlpOehBr6euFAR1bhYj/0L\n\tSEJeUWpHX6GobgkXsxsEdV0yWrybEDJZLfF7KRmk=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tUmang Jain ","Subject":"[PATCH v4 02/13] libcamera: mali-c55: Limit ISP input size","Date":"Tue, 9 Jul 2024 15:39:02 +0100","Message-Id":"<20240709143913.3276983-3-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","References":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nThe Mali-C55 ISP has a minimum input size limit of 640x480.\n\nFilter out resolutions smaller than this when selecting the\nsensor format. While at it, rename 'maxYuvSize' to a more\nappropriate 'minSensorSize'.\n\nReviewed-by: Daniel Scally \nReviewed-by: Umang Jain \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 38 ++++++++++++--------\n 1 file changed, 23 insertions(+), 15 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 1c1fef23..d1ae1a61 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -79,6 +79,7 @@ const std::map maliC55FmtToCode = {\n \t{ formats::SGRBG16, MEDIA_BUS_FMT_SGRBG16_1X16 },\n };\n \n+constexpr Size kMaliC55MinInputSize = { 640, 480 };\n constexpr Size kMaliC55MinSize = { 128, 128 };\n constexpr Size kMaliC55MaxSize = { 8192, 8192 };\n constexpr unsigned int kMaliC55ISPInternalFormat = MEDIA_BUS_FMT_RGB121212_1X36;\n@@ -265,13 +266,16 @@ PixelFormat MaliC55CameraData::adjustRawFormat(const PixelFormat &rawFmt) const\n \treturn rawFmt;\n }\n \n-Size MaliC55CameraData::adjustRawSizes(const PixelFormat &rawFmt, const Size &rawSize) const\n+Size MaliC55CameraData::adjustRawSizes(const PixelFormat &rawFmt, const Size &size) const\n {\n \t/* Just make sure the format is supported. */\n \tauto it = maliC55FmtToCode.find(rawFmt);\n \tif (it == maliC55FmtToCode.end())\n \t\treturn {};\n \n+\t/* Expand the RAW size to the minimum ISP input size. */\n+\tSize rawSize = size.expandedTo(kMaliC55MinInputSize);\n+\n \t/* Check if the size is natively supported. */\n \tunsigned int rawCode = it->second;\n \tconst auto rawSizes = sizes(rawCode);\n@@ -282,14 +286,14 @@ Size MaliC55CameraData::adjustRawSizes(const PixelFormat &rawFmt, const Size &ra\n \t/* Or adjust it to the closest supported size. */\n \tuint16_t distance = std::numeric_limits::max();\n \tSize bestSize;\n-\tfor (const Size &size : rawSizes) {\n+\tfor (const Size &sz : rawSizes) {\n \t\tuint16_t dist = std::abs(static_cast(rawSize.width) -\n-\t\t\t\t\t static_cast(size.width)) +\n+\t\t\t\t\t static_cast(sz.width)) +\n \t\t\t\tstd::abs(static_cast(rawSize.height) -\n-\t\t\t\t\t static_cast(size.height));\n+\t\t\t\t\t static_cast(sz.height));\n \t\tif (dist < distance) {\n \t\t\tdist = distance;\n-\t\t\tbestSize = size;\n+\t\t\tbestSize = sz;\n \t\t}\n \t}\n \n@@ -376,8 +380,13 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\tfrPipeAvailable = false;\n \t}\n \n-\t/* Adjust processed streams. */\n-\tSize maxYuvSize;\n+\t/*\n+\t * Adjust processed streams.\n+\t *\n+\t * Compute the minimum sensor size to be later used to select the\n+\t * sensor configuration.\n+\t */\n+\tSize minSensorSize = kMaliC55MinInputSize;\n \tfor (StreamConfiguration &config : config_) {\n \t\tif (isFormatRaw(config.pixelFormat))\n \t\t\tcontinue;\n@@ -399,8 +408,8 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\tstatus = Adjusted;\n \t\t}\n \n-\t\tif (maxYuvSize < size)\n-\t\t\tmaxYuvSize = size;\n+\t\tif (minSensorSize < size)\n+\t\t\tminSensorSize = size;\n \n \t\tif (frPipeAvailable) {\n \t\t\tconfig.setStream(const_cast(&data_->frStream_));\n@@ -416,7 +425,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \tif (rawConfig) {\n \t\tconst auto it = maliC55FmtToCode.find(rawConfig->pixelFormat);\n \t\tsensorFormat_.code = it->second;\n-\t\tsensorFormat_.size = rawConfig->size;\n+\t\tsensorFormat_.size = rawConfig->size.expandedTo(minSensorSize);\n \n \t\treturn status;\n \t}\n@@ -430,14 +439,13 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \tconst auto sizes = data_->sizes(it->second);\n \tSize bestSize;\n \tfor (const auto &size : sizes) {\n-\t\t/* Skip sensor sizes that are smaller than the max YUV size. */\n-\t\tif (maxYuvSize.width > size.width ||\n-\t\t maxYuvSize.height > size.height)\n+\t\tif (minSensorSize.width > size.width ||\n+\t\t minSensorSize.height > size.height)\n \t\t\tcontinue;\n \n-\t\tuint16_t dist = std::abs(static_cast(maxYuvSize.width) -\n+\t\tuint16_t dist = std::abs(static_cast(minSensorSize.width) -\n \t\t\t\t\t static_cast(size.width)) +\n-\t\t\t\tstd::abs(static_cast(maxYuvSize.height) -\n+\t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n \t\t\t\t\t static_cast(size.height));\n \t\tif (dist < distance) {\n \t\t\tdist = distance;\n","prefixes":["v4","02/13"]}