{"id":20618,"url":"https://patchwork.libcamera.org/api/1.1/patches/20618/?format=json","web_url":"https://patchwork.libcamera.org/patch/20618/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240709143913.3276983-2-dan.scally@ideasonboard.com>","date":"2024-07-09T14:39:01","name":"[v4,01/13] libcamera: mali-c55: Limit max size to sensor resolution","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0d1de27224076e1ea206f122fdcbb4eb8341642b","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20618/mbox/","series":[{"id":4448,"url":"https://patchwork.libcamera.org/api/1.1/series/4448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4448","date":"2024-07-09T14:39:00","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/4448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20618/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20618/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67A5CBDB1C\n\tfor ;\n\tTue, 9 Jul 2024 14:39:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 059536337F;\n\tTue, 9 Jul 2024 16:39:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E249619C1\n\tfor ;\n\tTue, 9 Jul 2024 16:39:20 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C1A716C3;\n\tTue, 9 Jul 2024 16:38:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FdChxek9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720535927;\n\tbh=kGF5kMqdHRI9qnD49DVIAMqqroOG26NPu6xcaqD1H5E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FdChxek9JCWFH66xIMWZiWINkGjQAxeQnUh+ds5kdQtuxRXOtwP+ZmDTY6az8BAFC\n\tFqgiU8kEhxnk6aIqdDZVUVpdZTYf5G/UwQmNTbvQr5OYqDLE9a5dyxJidLGvOm3CQC\n\tAv3bIC8KypZjj5AqBOOV0H1th2tOD2TPMpmMQ1Zk=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tUmang Jain ,\n\tKieran Bingham ","Subject":"[PATCH v4 01/13] libcamera: mali-c55: Limit max size to sensor\n\tresolution","Date":"Tue, 9 Jul 2024 15:39:01 +0100","Message-Id":"<20240709143913.3276983-2-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","References":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nThe Mali C55 ISP cannot upscale. The maximum allowed output size\nis the sensor's resolution.\n\nFor RAW streams this is already handled in adjustRawSizes(), while\nfor processed streams the maximum allowed resolution was wrongly\nset to the ISP maximum output size (8192x8192).\n\nReviewed-by: Daniel Scally \nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 45c71c1d..1c1fef23 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\trawConfig = &config;\n \t}\n \n-\tSize maxSize = kMaliC55MaxSize;\n+\t/*\n+\t * The C55 can not upscale. Limit the configuration to the ISP\n+\t * capabilities and the sensor resolution.\n+\t */\n+\tSize maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());\n \tif (rawConfig) {\n \t\t/*\n \t\t * \\todo Take into account the Bayer components ordering once\n","prefixes":["v4","01/13"]}