{"id":20606,"url":"https://patchwork.libcamera.org/api/1.1/patches/20606/?format=json","web_url":"https://patchwork.libcamera.org/patch/20606/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240705144209.418906-18-stefan.klug@ideasonboard.com>","date":"2024-07-05T14:41:53","name":"[v4,17/23] libtuning: Handle cases, where no lsc tuning images are present","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9b361da399bcd7f47d0f77bc025ffe08a6393ec4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20606/mbox/","series":[{"id":4446,"url":"https://patchwork.libcamera.org/api/1.1/series/4446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4446","date":"2024-07-05T14:41:36","name":"Add ccm calibration to libtuning","version":4,"mbox":"https://patchwork.libcamera.org/series/4446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20606/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20606/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4867CBD87C\n\tfor ;\n\tFri, 5 Jul 2024 14:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E36D863372;\n\tFri, 5 Jul 2024 16:43:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4114763367\n\tfor ;\n\tFri, 5 Jul 2024 16:42:57 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A626D4CC;\n\tFri, 5 Jul 2024 16:42:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e1xSadZQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190547;\n\tbh=VWj/b/Xo6deVmGHcq39poRTPcLfAjssyVN38VlqdnJE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e1xSadZQbhYqc5eC2lBd569OkFYKnt6bgyvQDgoX+rUMe4beePo6eXp2SR5/R56Vq\n\taPOHzKoQYtBqukPcSob1Snof/UpRVdovHbD/AF/6Om+JTzuq13nYrAt/ATa4pQpsK3\n\tLBgM5RiD9PqP8YgmnKTZQvpCrtUO56hNYzEdNQDA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[PATCH v4 17/23] libtuning: Handle cases,\n\twhere no lsc tuning images are present","Date":"Fri, 5 Jul 2024 16:41:53 +0200","Message-ID":"<20240705144209.418906-18-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make it clear that no lsc calibration was done by returning None instead\nof a incomplete configuration.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n---\n utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\nindex 57004104fc7a..512233aeae9d 100644\n--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n@@ -107,6 +107,9 @@ class LSCRkISP1(LSC):\n \n output['sets'] = self._do_all_lsc(images)\n \n+ if len(output['sets']) == 0:\n+ return None\n+\n # \\todo Validate images from greyscale camera and force grescale mode\n # \\todo Debug functionality\n \n","prefixes":["v4","17/23"]}