{"id":20599,"url":"https://patchwork.libcamera.org/api/1.1/patches/20599/?format=json","web_url":"https://patchwork.libcamera.org/patch/20599/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240705144209.418906-11-stefan.klug@ideasonboard.com>","date":"2024-07-05T14:41:46","name":"[v4,10/23] libtuning: Implement a minimal yaml parser","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a4d334a5a744a6b09a26c966ed5cefb909f295f4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20599/mbox/","series":[{"id":4446,"url":"https://patchwork.libcamera.org/api/1.1/series/4446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4446","date":"2024-07-05T14:41:36","name":"Add ccm calibration to libtuning","version":4,"mbox":"https://patchwork.libcamera.org/series/4446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20599/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20599/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BCF2BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jul 2024 14:42:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0340C63367;\n\tFri,  5 Jul 2024 16:42:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE84B619C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jul 2024 16:42:38 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5899E4CC;\n\tFri,  5 Jul 2024 16:42:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dmE05vrN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190529;\n\tbh=QLzmsrZJD4p2yyDrdaopL/53SEkuwl5v9CLDaSjQzWY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dmE05vrNaaSTHSSTqDIPwd9F6Xdtlncx7rh1NBRDdB4lYPf6nApvUJ0DTiPFms6fF\n\tdphko4G6uK8go+UQA62YsIEMz7HDmEHlsv0jRpaDEC6Jfcaeb+Xa6PxCfoSUPtRRTa\n\t5nh+6ozasAkReWW+csMOdoQkR1/niOqABL3g5dhA=","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Subject":"[PATCH v4 10/23] libtuning: Implement a minimal yaml parser","Date":"Fri,  5 Jul 2024 16:41:46 +0200","Message-ID":"<20240705144209.418906-11-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"At the moment this just reads the yaml file and returns it verbatim.\nThis needs to evolve further in the near future.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/tuning/config-example.yaml              | 12 ++++++++++++\n utils/tuning/libtuning/parsers/yaml_parser.py |  9 ++++++---\n 2 files changed, 18 insertions(+), 3 deletions(-)\n create mode 100644 utils/tuning/config-example.yaml","diff":"diff --git a/utils/tuning/config-example.yaml b/utils/tuning/config-example.yaml\nnew file mode 100644\nindex 000000000000..1b7f52cd2fff\n--- /dev/null\n+++ b/utils/tuning/config-example.yaml\n@@ -0,0 +1,12 @@\n+general:\n+  disable: []\n+  plot: []\n+  alsc:\n+    do_alsc_colour: 1\n+    luminance_strength: 0.5\n+  awb:\n+    greyworld: 0\n+  macbeth:\n+    small: 1\n+    show: 0\n+#  blacklevel: 32\n\\ No newline at end of file\ndiff --git a/utils/tuning/libtuning/parsers/yaml_parser.py b/utils/tuning/libtuning/parsers/yaml_parser.py\nindex 244db24daeb1..1fa6b7a86ddd 100644\n--- a/utils/tuning/libtuning/parsers/yaml_parser.py\n+++ b/utils/tuning/libtuning/parsers/yaml_parser.py\n@@ -5,13 +5,16 @@\n # Parser for YAML format config file\n \n from .parser import Parser\n+import yaml\n \n \n class YamlParser(Parser):\n     def __init__(self):\n         super().__init__()\n \n-    # \\todo Implement this (it's fine for now as we don't need a config for\n-    # rkisp1 LSC, which is the only user of this so far)\n     def parse(self, config_file: str, modules: list) -> (dict, list):\n-        return {}, []\n+        # Dummy implementation that just reads the file\n+        with open(config_file, 'r') as f:\n+            config = yaml.safe_load(f)\n+\n+        return config, []\n","prefixes":["v4","10/23"]}