{"id":20537,"url":"https://patchwork.libcamera.org/api/1.1/patches/20537/?format=json","web_url":"https://patchwork.libcamera.org/patch/20537/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240703141726.252368-24-stefan.klug@ideasonboard.com>","date":"2024-07-03T14:17:12","name":"[v3,23/23] libtuning: agc: rkisp1: Increase y-target","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"394b0d5b1f8a7c4879e8c6dc4763fa7a6b103dc9","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20537/mbox/","series":[{"id":4437,"url":"https://patchwork.libcamera.org/api/1.1/series/4437/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4437","date":"2024-07-03T14:16:49","name":"Add ccm calibration to libtuning","version":3,"mbox":"https://patchwork.libcamera.org/series/4437/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20537/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20537/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E107BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 14:18:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 212B863372;\n\tWed, 3 Jul 2024 16:18:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 636A663370\n\tfor ;\n\tWed, 3 Jul 2024 16:18:41 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9263:c199:9587:576])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 435994CA;\n\tWed, 3 Jul 2024 16:18:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rVboq7/6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720016293;\n\tbh=8REfSy+49hMeQ0J7u/T/NBeOTW1n8QoejuZ9uBZaysY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rVboq7/6nCPXjD3+cmfk208XDyuA21Shx9VRYAu8yn2u4YBVMM8joEGOvClMgBKcN\n\t2ERb15LQx1nlaS1cJ1k2Eh29dzdfc2B6bIojARM+wcazJk4BSoqNr6pmRHX3Ba9DJA\n\tGBnwnsq3rct4sZg31I+Ug/vZPk/gcUl1OZVLdAjA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 23/23] libtuning: agc: rkisp1: Increase y-target","Date":"Wed, 3 Jul 2024 16:17:12 +0200","Message-ID":"<20240703141726.252368-24-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With the addition of gamma out correction the relative luminance target\nwas set too low. As brightness is a bit subjective it is difficult to\ncome up with the \"correct\" value. With 0.5 the patch 22 on the mac beth\nchart (neutral grey, 18% reflectance) ended up a bit below 50% grey,\nwhich seems reasonable.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \n---\n utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\nindex 19a5555b6111..7147028a774a 100644\n--- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n@@ -64,7 +64,7 @@ class AGCRkISP1(AGC):\n return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}\n \n def _generate_y_target(self) -> list:\n- return 0.16\n+ return 0.5\n \n def process(self, config: dict, images: list, outputs: dict) -> dict:\n output = {}\n","prefixes":["v3","23/23"]}