{"id":20486,"url":"https://patchwork.libcamera.org/api/1.1/patches/20486/?format=json","web_url":"https://patchwork.libcamera.org/patch/20486/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","date":"2024-06-28T21:35:34","name":"[1/2] apps: common: dng_writer: Fix thumbnail generation on BE machines","commit_ref":"7735d65ce81db570570dc21bb6056da8abd2ae22","pull_url":null,"state":"accepted","archived":false,"hash":"9570a8f3a82b8aee86d626b38fcddc2564882375","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20486/mbox/","series":[{"id":4431,"url":"https://patchwork.libcamera.org/api/1.1/series/4431/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4431","date":"2024-06-28T21:35:33","name":"apps: common: dng_write: Endianness fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4431/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20486/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20486/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7CE9BD87C\n\tfor ;\n\tFri, 28 Jun 2024 21:36:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1FBB62C9F;\n\tFri, 28 Jun 2024 23:36:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0055662C95\n\tfor ;\n\tFri, 28 Jun 2024 23:35:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10A862C5\n\tfor ;\n\tFri, 28 Jun 2024 23:35:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G9zpe3dR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719610533;\n\tbh=j7YXVIhlBpY9+vSh/yt9XreDl5UBpm+4n4rSTlqjKsw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=G9zpe3dRHR3v6IuVu7nRo5fLOE3n/WRuk1XfEIAMqBrM6hOKJNRq1/h2gPuVcjrrk\n\tleVStOiI8YTeFUwC3DL3g2O+bLQyDYGwuMDt8jzxt0DFWDVeSWlxnmAq1EI0OK2bYM\n\ti1DdFNy0quu4nLafbzygq17YNYHO0ifRU23AL0BI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation on BE\n\tmachines","Date":"Sat, 29 Jun 2024 00:35:34 +0300","Message-ID":"<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>","References":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 16-bit padded raw 10 and raw 12 formats are stored in memory in\nlittle endian order, regardless of the machine's endianness. Swap the\n16-bit values on big-endian machines when reading pixels from memory to\ngenerate thumbnails.\n\nSigned-off-by: Laurent Pinchart \n---\n src/apps/common/dng_writer.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 9241f23fb806..50db5eb33c83 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -8,6 +8,7 @@\n #include \"dng_writer.h\"\n \n #include \n+#include \n #include \n #include \n \n@@ -185,7 +186,8 @@ void thumbScanlineRaw(const FormatInfo &info, void *output, const void *input,\n \n \t/* Simple averaging that produces greyscale RGB values. */\n \tfor (unsigned int x = 0; x < width; x++) {\n-\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n+\t\tuint16_t value = (le16toh(in[0]) + le16toh(in[1]) +\n+\t\t\t\t le16toh(in2[0]) + le16toh(in2[1])) >> 2;\n \t\tvalue = value >> shift;\n \t\t*out++ = value;\n \t\t*out++ = value;\n","prefixes":["1/2"]}