{"id":20480,"url":"https://patchwork.libcamera.org/api/1.1/patches/20480/?format=json","web_url":"https://patchwork.libcamera.org/patch/20480/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240628104828.2928109-22-stefan.klug@ideasonboard.com>","date":"2024-06-28T10:47:14","name":"[v2,21/25] libtuning: lsc: rkisp1: Do not calculate ratios to green","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3b0df8b478369eba013e6edaf3a8164fa7f983fb","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20480/mbox/","series":[{"id":4430,"url":"https://patchwork.libcamera.org/api/1.1/series/4430/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4430","date":"2024-06-28T10:46:53","name":"Add ccm calibration to libtuning","version":2,"mbox":"https://patchwork.libcamera.org/series/4430/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20480/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20480/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACECBBD87C\n\tfor ;\n\tFri, 28 Jun 2024 10:49:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57CD063362;\n\tFri, 28 Jun 2024 12:49:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4E9663364\n\tfor ;\n\tFri, 28 Jun 2024 12:49:38 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D165BEB;\n\tFri, 28 Jun 2024 12:49:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o8ItG90D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571754;\n\tbh=2zxpM60NvWBn0Cvt+ZszmNAx++DCfCg937M0yauWIwc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o8ItG90DGwSpP43KYN1fsFIU+2wZASjUN3ifO1F12WXL3peBhq1ffXvhAnaGLUdgn\n\t7n7dyhILGi0OwMgvgmxMQEw7vJx2X63Bk4o/pnaGGSydv6wjEGkL40OO9f1xq9j1h4\n\tvIKz2oYFp4bPAB82mr4vhAg8eL3TUOVVtma5dkqU=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 21/25] libtuning: lsc: rkisp1: Do not calculate ratios to\n\tgreen","Date":"Fri, 28 Jun 2024 12:47:14 +0200","Message-ID":"<20240628104828.2928109-22-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The hardware in the imx8mp treats the lsc tables as absolute factors and\nnot as ratios compared to green. Therefore every channel must calculated\nindependently.\n\nSigned-off-by: Stefan Klug \n---\n utils/tuning/libtuning/modules/lsc/rkisp1.py | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\nindex 5874f10c936f..a8ba454a7139 100644\n--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n@@ -38,8 +38,11 @@ class LSCRkISP1(LSC):\n \n # \\todo Should these ratio against the average of both greens or just\n # each green like we've done here?\n- cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, gr)\n- cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, gb)\n+\n+ # the lsc tables in the rkisp1 are gains on the corresponding channel,\n+ # not ratios with respect to green, so calculate them independently\n+ cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, None)\n+ cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, None)\n \n return image.color, cr.flatten(), cb.flatten(), cgr.flatten(), cgb.flatten()\n \n","prefixes":["v2","21/25"]}