{"id":20446,"url":"https://patchwork.libcamera.org/api/1.1/patches/20446/?format=json","web_url":"https://patchwork.libcamera.org/patch/20446/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627145156.1094127-11-mzamazal@redhat.com>","date":"2024-06-27T14:51:47","name":"[v3,10/14] config: Look up pipelines match list in configuration file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a4c81defedc9f90459447c381630b5da36b58f67","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20446/mbox/","series":[{"id":4426,"url":"https://patchwork.libcamera.org/api/1.1/series/4426/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4426","date":"2024-06-27T14:51:37","name":"Add global configuration file","version":3,"mbox":"https://patchwork.libcamera.org/series/4426/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20446/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20446/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7435BD87C\n\tfor ;\n\tThu, 27 Jun 2024 14:52:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CFF762E25;\n\tThu, 27 Jun 2024 16:52:58 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D56462C9D\n\tfor ;\n\tThu, 27 Jun 2024 16:52:54 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-495-0UdWqDqsPI2qnT87Umao9g-1;\n\tThu, 27 Jun 2024 10:52:50 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 7EE731955D8E; Thu, 27 Jun 2024 14:52:49 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.47])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1DE101955BD4; Thu, 27 Jun 2024 14:52:47 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Q4EbjneH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719499973;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=xZmaibSI/9GVkZJQbkCmtUFceJFGssWw7Ct7aYJoDmo=;\n\tb=Q4EbjneHely/nsRZSs6+RapaNl9vuHKTfyBL1DGqdNgCxomfQ/nSeApfjwWM4Fuop3aI7M\n\tOgWFCOlvt+6TO5Ce0IMID7QZeV32DIwYeaxnBC6YV4L9iOcXG5d61oareG1QeBHBWPAYnE\n\tXmBKtWZhQ4Iy1NoAz2Mk/75py7zdFkw=","X-MC-Unique":"0UdWqDqsPI2qnT87Umao9g-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v3 10/14] config: Look up pipelines match list in\n\tconfiguration file","Date":"Thu, 27 Jun 2024 16:51:47 +0200","Message-ID":"<20240627145156.1094127-11-mzamazal@redhat.com>","In-Reply-To":"<20240627145156.1094127-1-mzamazal@redhat.com>","References":"<20240627145156.1094127-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Milan Zamazal \n---\n src/libcamera/camera_manager.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 7c5e5606..836a7bc9 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -113,14 +113,15 @@ void CameraManager::Private::createPipelineHandlers()\n \t * file and only fallback on environment variable or all handlers, if\n \t * there is no configuration file.\n \t */\n-\tconst char *pipesList =\n-\t\tutils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n-\tif (pipesList) {\n+\tstd::optional pipesList =\n+\t\tGlobalConfiguration::envOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n+\t\t\t\t\t \"pipelines_match_list\");\n+\tif (pipesList.has_value()) {\n \t\t/*\n \t\t * When a list of preferred pipelines is defined, iterate\n \t\t * through the ordered list to match the enumerated devices.\n \t\t */\n-\t\tfor (const auto &pipeName : utils::split(pipesList, \",\")) {\n+\t\tfor (const auto &pipeName : utils::split(pipesList.value(), \",\")) {\n \t\t\tconst PipelineHandlerFactoryBase *factory;\n \t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n \t\t\tif (!factory)\n","prefixes":["v3","10/14"]}