{"id":20427,"url":"https://patchwork.libcamera.org/api/1.1/patches/20427/?format=json","web_url":"https://patchwork.libcamera.org/patch/20427/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627125310.2533622-3-stefan.klug@ideasonboard.com>","date":"2024-06-27T12:51:10","name":"[2/3] apps: common: dng_writer: Add thumbnail scanline function for RawXX","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a88ac662e940caaa0f1dfbf328ad444c52b0f3c6","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20427/mbox/","series":[{"id":4423,"url":"https://patchwork.libcamera.org/api/1.1/series/4423/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4423","date":"2024-06-27T12:51:08","name":"dng_writer: Add support for RAW10 and RAW 12","version":1,"mbox":"https://patchwork.libcamera.org/series/4423/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20427/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20427/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C45EEBD87C\n\tfor ;\n\tThu, 27 Jun 2024 12:53:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 751AE62C9D;\n\tThu, 27 Jun 2024 14:53:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F87762C98\n\tfor ;\n\tThu, 27 Jun 2024 14:53:42 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6248:8b4b:42bc:2b84])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61F0E2E0;\n\tThu, 27 Jun 2024 14:53:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wBrMEbmN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719492798;\n\tbh=YdteIK+RlX3MCfQxROWXtSR7PlZy6FqL60WS/CdvUsI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wBrMEbmNF3zzLSw7adUwBZAmbYIIJSG2pM3HyFfPfQtCExDYaMWMVnAo5ijS+tK2s\n\tza66TgZCA+X/ATmEs8W1DdR+mxUkRcAdSQmSFlvalJBlKcB2V7dZFOD8ZxqbZRc6x1\n\tpaVhGMOoXksW3a1cRo885nlt313LBdcBME1t3pA8=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 2/3] apps: common: dng_writer: Add thumbnail scanline\n\tfunction for RawXX","Date":"Thu, 27 Jun 2024 14:51:10 +0200","Message-ID":"<20240627125310.2533622-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a thumbnail function for raw formats that are 16bit aligned.\nThis is needed for the upcoming RAW10 and RAW12 implemntation.\n\nUse the new function for RAW16 as the thumbScanlineRawXX_CSI2P produces\nincorrect results for that format (it averages over adjacent bytes,\nwhich works for the CSI formats).\n\nSigned-off-by: Stefan Klug \n---\n src/apps/common/dng_writer.cpp | 32 ++++++++++++++++++++++++++++----\n 1 file changed, 28 insertions(+), 4 deletions(-)","diff":"diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 88b225d3e099..2cb320ff327b 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -144,6 +144,30 @@ void packScanlineRaw16(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n+/* Thumbnail function for raw data aligned to 16bit words */\n+void thumbScanlineRawXX(const FormatInfo &info, void *output,\n+\t\t\t const void *input, unsigned int width,\n+\t\t\t unsigned int stride)\n+{\n+\tconst uint16_t *in = static_cast(input);\n+\tconst uint16_t *in2 = static_cast(input) + stride / 2;\n+\tuint8_t *out = static_cast(output);\n+\n+\t/* shift down to 8 */\n+\tunsigned int shift = info.bitsPerSample - 8;\n+\n+\t/* simple averaging that produces grey RGB values */\n+\tfor (unsigned int x = 0; x < width; x++) {\n+\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n+\t\tvalue = value >> shift;\n+\t\t*out++ = value;\n+\t\t*out++ = value;\n+\t\t*out++ = value;\n+\t\tin += 16;\n+\t\tin2 += 16;\n+\t}\n+}\n+\n void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast(input);\n@@ -321,25 +345,25 @@ const std::map formatInfo = {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n \t} },\n \t{ formats::SGBRG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n \t} },\n \t{ formats::SGRBG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n \t} },\n \t{ formats::SRGGB16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n \t} },\n \t{ formats::SBGGR10_CSI2P, {\n \t\t.bitsPerSample = 10,\n","prefixes":["2/3"]}