{"id":20426,"url":"https://patchwork.libcamera.org/api/1.1/patches/20426/?format=json","web_url":"https://patchwork.libcamera.org/patch/20426/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627125310.2533622-2-stefan.klug@ideasonboard.com>","date":"2024-06-27T12:51:09","name":"[1/3] apps: common: dng_writer: Rename packing functions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f8afe50c3ee034186c13ee2236be152f5c5a6d09","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20426/mbox/","series":[{"id":4423,"url":"https://patchwork.libcamera.org/api/1.1/series/4423/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4423","date":"2024-06-27T12:51:08","name":"dng_writer: Add support for RAW10 and RAW 12","version":1,"mbox":"https://patchwork.libcamera.org/series/4423/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20426/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20426/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D74ABD87C\n\tfor ;\n\tThu, 27 Jun 2024 12:53:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB97462C95;\n\tThu, 27 Jun 2024 14:53:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E002B62C95\n\tfor ;\n\tThu, 27 Jun 2024 14:53:35 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6248:8b4b:42bc:2b84])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FFB72E0;\n\tThu, 27 Jun 2024 14:53:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LtJsq83m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719492792;\n\tbh=DSqodPtS3kfZV5MDSgZJWU9R1MjslJrKFnncimoleNg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LtJsq83mhONyxKumi/+5DlIePGMK8JwoooTWNX25/kucQW5+E0r3ddCaBXyCxsWbE\n\t3KxsgPRBPjTe/7kQnZtOGzEM9lw3PMs/kqq/Xva6TMEqpuJWd6oQjtoe3t/gB1tEYJ\n\tQtRNRclhoIn7n0Qucq/WEIo0zRAD2/paT67Hnnxo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 1/3] apps: common: dng_writer: Rename packing functions","Date":"Thu, 27 Jun 2024 14:51:09 +0200","Message-ID":"<20240627125310.2533622-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The old names lead to confusions. Rename to better express the intent.\n\nSigned-off-by: Stefan Klug \n---\n src/apps/common/dng_writer.cpp | 74 +++++++++++++++++-----------------\n 1 file changed, 37 insertions(+), 37 deletions(-)","diff":"diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex d37b0d627cd1..88b225d3e099 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -128,7 +128,7 @@ struct Matrix3d {\n \n namespace {\n \n-void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n+void packScanlineRaw8(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast(input);\n \tuint8_t *out = static_cast(output);\n@@ -136,7 +136,7 @@ void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n-void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n+void packScanlineRaw16(void *output, const void *input, unsigned int width)\n {\n \tconst uint16_t *in = static_cast(input);\n \tuint16_t *out = static_cast(output);\n@@ -144,7 +144,7 @@ void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n-void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n+void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast(input);\n \tuint8_t *out = static_cast(output);\n@@ -160,7 +160,7 @@ void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n \t}\n }\n \n-void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n+void packScanlineRaw12_CSI2P(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast(input);\n \tuint8_t *out = static_cast(output);\n@@ -174,7 +174,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n \t}\n }\n \n-void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n+void thumbScanlineRawXX_CSI2P(const FormatInfo &info, void *output,\n \t\t\t const void *input, unsigned int width,\n \t\t\t unsigned int stride)\n {\n@@ -296,98 +296,98 @@ const std::map formatInfo = {\n \t{ formats::SBGGR8, {\n \t\t.bitsPerSample = 8,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n-\t\t.packScanline = packScanlineSBGGR8,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw8,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGBRG8, {\n \t\t.bitsPerSample = 8,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR8,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw8,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGRBG8, {\n \t\t.bitsPerSample = 8,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR8,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw8,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SRGGB8, {\n \t\t.bitsPerSample = 8,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n-\t\t.packScanline = packScanlineSBGGR8,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw8,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SBGGR16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n-\t\t.packScanline = packScanlineSBGGR16,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw16,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGBRG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR16,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw16,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGRBG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR16,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw16,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SRGGB16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n-\t\t.packScanline = packScanlineSBGGR16,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw16,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SBGGR10_CSI2P, {\n \t\t.bitsPerSample = 10,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n-\t\t.packScanline = packScanlineSBGGR10P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw10_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGBRG10_CSI2P, {\n \t\t.bitsPerSample = 10,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR10P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw10_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGRBG10_CSI2P, {\n \t\t.bitsPerSample = 10,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR10P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw10_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SRGGB10_CSI2P, {\n \t\t.bitsPerSample = 10,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n-\t\t.packScanline = packScanlineSBGGR10P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw10_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SBGGR12_CSI2P, {\n \t\t.bitsPerSample = 12,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n-\t\t.packScanline = packScanlineSBGGR12P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw12_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGBRG12_CSI2P, {\n \t\t.bitsPerSample = 12,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR12P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw12_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SGRBG12_CSI2P, {\n \t\t.bitsPerSample = 12,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n-\t\t.packScanline = packScanlineSBGGR12P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw12_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SRGGB12_CSI2P, {\n \t\t.bitsPerSample = 12,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n-\t\t.packScanline = packScanlineSBGGR12P,\n-\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t\t.packScanline = packScanlineRaw12_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n \t{ formats::SBGGR10_IPU3, {\n \t\t.bitsPerSample = 16,\n","prefixes":["1/3"]}