{"id":20387,"url":"https://patchwork.libcamera.org/api/1.1/patches/20387/?format=json","web_url":"https://patchwork.libcamera.org/patch/20387/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240625190423.291429-2-jacopo.mondi@ideasonboard.com>","date":"2024-06-25T19:04:14","name":"[v2,1/6] libcamera: mali-c55: Limit max size to sensor resolution","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0d1de27224076e1ea206f122fdcbb4eb8341642b","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20387/mbox/","series":[{"id":4418,"url":"https://patchwork.libcamera.org/api/1.1/series/4418/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4418","date":"2024-06-25T19:04:13","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/4418/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20387/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20387/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45515BDB1D\n\tfor ;\n\tTue, 25 Jun 2024 19:04:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B938654B1;\n\tTue, 25 Jun 2024 21:04:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E07F654A2\n\tfor ;\n\tTue, 25 Jun 2024 21:04:36 +0200 (CEST)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DC25BEB;\n\tTue, 25 Jun 2024 21:04:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jx3QZM+T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719342253;\n\tbh=B1Lv2Ur0rqNdwO7o95xpnCF7fCVJ2TWUMiC+sfgKslE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jx3QZM+T3Ldxox2sEwEOgD/ewM/cIn7QMQwo6wssIz/gnVzktdfxNt2Ys9c/JCEO7\n\tcpOFi/HjfOHAY//7vP+JhbbuyY3E64c0tGeS3Z3y5SbdPshonDW4KMr9Yh4vdMFoG8\n\tvY1t0c9rnkZ8hIiLnO4VRdr/YiZ7MkxN8qSRgdwM=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tKieran Bingham ","Subject":"[PATCH v2 1/6] libcamera: mali-c55: Limit max size to sensor\n\tresolution","Date":"Tue, 25 Jun 2024 21:04:14 +0200","Message-ID":"<20240625190423.291429-2-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>","References":"<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Mali C55 ISP cannot upscale. The maximum allowed output size\nis the sensor's resolution.\n\nFor RAW streams this is already handled in adjustRawSizes(), while\nfor processed streams the maximum allowed resolution was wrongly\nset to the ISP maximum output size (8192x8192).\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \nReviewed-by: Kieran Bingham \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 45c71c1dd619..1c1fef2337f0 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\trawConfig = &config;\n \t}\n \n-\tSize maxSize = kMaliC55MaxSize;\n+\t/*\n+\t * The C55 can not upscale. Limit the configuration to the ISP\n+\t * capabilities and the sensor resolution.\n+\t */\n+\tSize maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());\n \tif (rawConfig) {\n \t\t/*\n \t\t * \\todo Take into account the Bayer components ordering once\n","prefixes":["v2","1/6"]}