{"id":20340,"url":"https://patchwork.libcamera.org/api/1.1/patches/20340/?format=json","web_url":"https://patchwork.libcamera.org/patch/20340/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:39:10","name":"[12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC algorithm","commit_ref":"13a8fbeb5c8d10524f357b4f2eb566b7243d0b94","pull_url":null,"state":"accepted","archived":false,"hash":"8817435fa6297676844e406b8f31e99abdda77a1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20340/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/1.1/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20340/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20340/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B298AC32CF\n\tfor ;\n\tSun, 16 Jun 2024 16:40:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C812654A7;\n\tSun, 16 Jun 2024 18:40:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BC6D65456\n\tfor ;\n\tSun, 16 Jun 2024 18:39:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A376581\n\tfor ;\n\tSun, 16 Jun 2024 18:39:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NISr7vM/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555971;\n\tbh=vbZEaBuhxyxSTiN4bA+ueKmgglndFXZr11EeC948W98=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NISr7vM/x4CMoVz8lYZU77G72tgE4gVAoNKfOYG2/kHg3jSbLwzBcu6qxBB+qFO14\n\tDT4fCnBnVnZ9oXb3BbWSAgqmIhw6bioVHpLGlfWrXIk7SrrzfozZn/1UbFe7UlEHFT\n\t/g6B2iSLk5waGAb9E4Yvwu3hkV96zFOpV2POY7zQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC\n\talgorithm","Date":"Sun, 16 Jun 2024 19:39:10 +0300","Message-ID":"<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The AGC algorithm implements the AeEnable control at runtime. Move the\ndeclaration of the control from the IPA module to the algorithm.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 1 -\n 2 files changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 0018c43f18cf..965030b62de5 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -148,6 +148,7 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n \tif (ret)\n \t\treturn ret;\n \n+\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n \tcontext.ctrlMap.merge(controls());\n \n \treturn 0;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 62d56a3ae44a..d31cdbab020b 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -106,7 +106,6 @@ const IPAHwSettings ipaHwSettingsV12{\n \n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n-\t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n","prefixes":["12/12"]}