{"id":20339,"url":"https://patchwork.libcamera.org/api/1.1/patches/20339/?format=json","web_url":"https://patchwork.libcamera.org/patch/20339/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-12-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:39:09","name":"[11/12] ipa: rkisp1: agc: Correctly clamp maximum shutter speed","commit_ref":"4ce519cdc5f62a8b17861242f8ea830c9a8df1a1","pull_url":null,"state":"accepted","archived":false,"hash":"d18a96b98a2383b6b8cf13ff69ca984ac6c351f3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20339/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/1.1/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20339/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20339/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E30FFC32D1\n\tfor ;\n\tSun, 16 Jun 2024 16:40:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 479B6654A4;\n\tSun, 16 Jun 2024 18:40:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 485F6654A4\n\tfor ;\n\tSun, 16 Jun 2024 18:39:46 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E444A581\n\tfor ;\n\tSun, 16 Jun 2024 18:39:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nyBNZoxp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555970;\n\tbh=T64M81Hstr4clue5nu8JTOwU06Oj25vE6cgxpk5BQws=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=nyBNZoxp8XCrFqSu5p34M5cvWfszBlCWA13zQmXKXDWZKRSOcO5Su9Le2EVAjsAA5\n\t+sUN6DTPKuX7fGxGamoPNy3bXcqP6an9pvKKae9T2hGw3kQ/9XundGHXKg8OXy6Cve\n\t6vSaxU4nc73E7WWqx2mVh2Sf/yj0LCXKdGqmOzCM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 11/12] ipa: rkisp1: agc: Correctly clamp maximum shutter\n\tspeed","Date":"Sun, 16 Jun 2024 19:39:09 +0300","Message-ID":"<20240616163910.5506-12-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The sensor's maximum shutter speed is clamped by the maximum frame\nduration specified in requests. If the requested maximum frame duration\nis lower than the sensor's minimum shutter speed, the Agc::process()\nfunction will pass a minimum value higher than the maximum to the\nsetLimits() function, resulting in an assertion failure. Fix it by\nclamping the value to both the lower and the upper bounds.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 5b917557b887..0018c43f18cf 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -420,8 +420,10 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t\t [](uint32_t x) { return x >> 4; });\n \texpMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n \n-\tutils::Duration maxShutterSpeed = std::min(context.configuration.sensor.maxShutterSpeed,\n-\t\t\t\t\t\t frameContext.agc.maxFrameDuration);\n+\tutils::Duration maxShutterSpeed =\n+\t\tstd::clamp(frameContext.agc.maxFrameDuration,\n+\t\t\t context.configuration.sensor.minShutterSpeed,\n+\t\t\t context.configuration.sensor.maxShutterSpeed);\n \tsetLimits(context.configuration.sensor.minShutterSpeed,\n \t\t maxShutterSpeed,\n \t\t context.configuration.sensor.minAnalogueGain,\n","prefixes":["11/12"]}