{"id":20330,"url":"https://patchwork.libcamera.org/api/1.1/patches/20330/?format=json","web_url":"https://patchwork.libcamera.org/patch/20330/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-3-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:39:00","name":"[02/12] ipa: libipa: agc_mean_luminance: Fix enumerator names","commit_ref":"3faa04fe48b394e0c73056183293a5b77116e539","pull_url":null,"state":"accepted","archived":false,"hash":"be264694a5d809ef5252d6c5cd5e52d325b3ee79","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20330/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/1.1/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20330/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20330/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97E10C3237\n\tfor ;\n\tSun, 16 Jun 2024 16:39:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5232065497;\n\tSun, 16 Jun 2024 18:39:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DDC365490\n\tfor ;\n\tSun, 16 Jun 2024 18:39:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FEA6581\n\tfor ;\n\tSun, 16 Jun 2024 18:39:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cGH7JqIK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555958;\n\tbh=bKLtOf6T59SA9mfNixAx/+I8pUBY+yw0kkTKyQ+dW4U=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cGH7JqIKM9XPLuiJ5kuF7OIFZXEXoknaNBEh2oo0O0hQI09lJZ0HBly+L4YEo2PCY\n\to69gy55UL157XbW4DMEvZa9pJNvw7Fej1uuyTORyEDxp0lNMekgDD4vQ8tif+pOPqj\n\tUckWaLaOW1Jf1S05Ab7FZdkHHcvRSQ641UjiDwHY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 02/12] ipa: libipa: agc_mean_luminance: Fix enumerator names","Date":"Sun, 16 Jun 2024 19:39:00 +0300","Message-ID":"<20240616163910.5506-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Enumerators in libcamera start with an upper case letter. Fix the\nAgcConstraint::Bound enumerators.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/agc_mean_luminance.cpp | 10 +++++-----\n src/ipa/libipa/agc_mean_luminance.h | 4 ++--\n 2 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex 271b5ae4bc97..f97ef11771c4 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -59,9 +59,9 @@ static constexpr double kDefaultRelativeLuminanceTarget = 0.16;\n /**\n * \\enum AgcMeanLuminance::AgcConstraint::Bound\n * \\brief Specify whether the constraint defines a lower or upper bound\n- * \\var AgcMeanLuminance::AgcConstraint::lower\n+ * \\var AgcMeanLuminance::AgcConstraint::Lower\n * \\brief The constraint defines a lower bound\n- * \\var AgcMeanLuminance::AgcConstraint::upper\n+ * \\var AgcMeanLuminance::AgcConstraint::Upper\n * \\brief The constraint defines an upper bound\n */\n \n@@ -209,7 +209,7 @@ int AgcMeanLuminance::parseConstraintModes(const YamlObject &tuningData)\n \t */\n \tif (constraintModes_.empty()) {\n \t\tAgcConstraint constraint = {\n-\t\t\tAgcConstraint::Bound::lower,\n+\t\t\tAgcConstraint::Bound::Lower,\n \t\t\t0.98,\n \t\t\t1.0,\n \t\t\t0.5\n@@ -467,11 +467,11 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\tdouble newGain = constraint.yTarget * hist.bins() /\n \t\t\t\t hist.interQuantileMean(constraint.qLo, constraint.qHi);\n \n-\t\tif (constraint.bound == AgcConstraint::Bound::lower &&\n+\t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n \t\t newGain > gain)\n \t\t\tgain = newGain;\n \n-\t\tif (constraint.bound == AgcConstraint::Bound::upper &&\n+\t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n \t\t newGain < gain)\n \t\t\tgain = newGain;\n \t}\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex 0a81c6d285b8..d1bddda5d162 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -31,8 +31,8 @@ public:\n \n \tstruct AgcConstraint {\n \t\tenum class Bound {\n-\t\t\tlower = 0,\n-\t\t\tupper = 1\n+\t\t\tLower = 0,\n+\t\t\tUpper = 1\n \t\t};\n \t\tBound bound;\n \t\tdouble qLo;\n","prefixes":["02/12"]}