{"id":20329,"url":"https://patchwork.libcamera.org/api/1.1/patches/20329/?format=json","web_url":"https://patchwork.libcamera.org/patch/20329/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-2-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:38:59","name":"[01/12] ipa: rkisp1: agc: Fix initialization without metering modes","commit_ref":"8fd673deaf9beb2e9be9c81342f728c2b7b0513a","pull_url":null,"state":"accepted","archived":false,"hash":"a485cec6cf0e7d867847cc6d9e490555e3d0effb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20329/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/1.1/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20329/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20329/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31E3CC3293\n\tfor ;\n\tSun, 16 Jun 2024 16:39:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51B1F65489;\n\tSun, 16 Jun 2024 18:39:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16B0D65456\n\tfor ;\n\tSun, 16 Jun 2024 18:39:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDFC7581\n\tfor ;\n\tSun, 16 Jun 2024 18:39:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O87Kl/UN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555956;\n\tbh=iR8y/Opgedt1TxZ6K4koPl5aVQAl8MKbwjL3MeBy+8I=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=O87Kl/UNl6WvFvPadfktVkFyOFyAF1IWn1RxA6HapNmE8iBeRYxERlF8GM7WhTUIl\n\tIUf5O/LCUlJcQ9agXXWxbYpilhmKSXZTmQrwwFRwPoDJjg0Z2kqJBZa1I7OrBZM70H\n\tgwYyisUTY0Z1tQP/aDycdyPmvSjJ2RwFicVtugiI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 01/12] ipa: rkisp1: agc: Fix initialization without metering\n\tmodes","Date":"Sun, 16 Jun 2024 19:38:59 +0300","Message-ID":"<20240616163910.5506-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When no metering modes are specified in the tuning file, the AGC\ninitialzation fails with\n\n[0:00:46.148508875] [209] ERROR RkISP1Agc agc.cpp:46 'AeMeteringMode' parameter not found in tuning file\n\nwhich results in a camera initialization failure. Fix it by downgrading\nthe error into a warning, and continuing the AGC initialization with the\ndefault metering mode.\n\nFixes: 35233938ee5d (\"ipa: rkisp1: agc: Read histogram weights from tuning file\")\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 8702145187c7..0f60d08fd41c 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -42,11 +42,9 @@ LOG_DEFINE_CATEGORY(RkISP1Agc)\n \n int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData)\n {\n-\tif (!tuningData.isDictionary()) {\n-\t\tLOG(RkISP1Agc, Error)\n+\tif (!tuningData.isDictionary())\n+\t\tLOG(RkISP1Agc, Warning)\n \t\t\t<< \"'AeMeteringMode' parameter not found in tuning file\";\n-\t\treturn -EINVAL;\n-\t}\n \n \tfor (const auto &[key, value] : tuningData.asDict()) {\n \t\tif (controls::AeMeteringModeNameValueMap.find(key) ==\n","prefixes":["01/12"]}