{"id":20285,"url":"https://patchwork.libcamera.org/api/1.1/patches/20285/?format=json","web_url":"https://patchwork.libcamera.org/patch/20285/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240613083533.855791-2-stefan.klug@ideasonboard.com>","date":"2024-06-13T08:33:18","name":"[1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit symbol visibility","commit_ref":"9b84d75cb101d129e00ff9696ccd329eb8a4c461","pull_url":null,"state":"accepted","archived":false,"hash":"4815388416ea20c95ee35ce1ac501f83affa5359","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20285/mbox/","series":[{"id":4387,"url":"https://patchwork.libcamera.org/api/1.1/series/4387/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4387","date":"2024-06-13T08:33:17","name":"ipa: rkisp1: cproc: Small fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4387/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20285/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20285/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69CCCC3237\n\tfor ;\n\tThu, 13 Jun 2024 08:36:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F5FB65491;\n\tThu, 13 Jun 2024 10:36:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 115B66548B\n\tfor ;\n\tThu, 13 Jun 2024 10:36:36 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3fed:9d83:54f9:6b93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 336BEBEB;\n\tThu, 13 Jun 2024 10:36:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hc9cnOZ8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718267782;\n\tbh=8o5C02XcJNF0ptiQqO2BtH83TIZKQk1Xb0wMfDNiWso=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hc9cnOZ8xVJAjckEGcxrqbQAjLOlMMSgkRaR+okSf/wC0uABigKx50EJQZApb+t+u\n\tvzpZhouIZITRno8VNE0c9+edCZ9uAiUSePXJYOc0HPgdo41dpdYYdc6LZzGUkVac9q\n\tfKyVI/fDC1E6vdEHdl2jZBBa2YWcGh5RKiUme97w=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit\n\tsymbol visibility","Date":"Thu, 13 Jun 2024 10:33:18 +0200","Message-ID":"<20240613083533.855791-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use a anonymous namespace instead of the static keyword to limity symbol\nvisibility.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/cproc.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\nindex 18c7b719d3c7..955298093fda 100644\n--- a/src/ipa/rkisp1/algorithms/cproc.cpp\n+++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n@@ -33,25 +33,29 @@ namespace ipa::rkisp1::algorithms {\n \n LOG_DEFINE_CATEGORY(RkISP1CProc)\n \n+namespace {\n+\n constexpr float kDefaultBrightness = 0.0f;\n constexpr float kDefaultContrast = 1.0f;\n constexpr float kDefaultSaturation = 1.0f;\n \n-static int convertBrightness(const float v)\n+int convertBrightness(const float v)\n {\n \treturn std::clamp(std::lround(v * 128), -128, 127);\n }\n \n-static int convertContrast(const float v)\n+int convertContrast(const float v)\n {\n \treturn std::clamp(std::lround(v * 128), 0, 255);\n }\n \n-static int convertSaturation(const float v)\n+int convertSaturation(const float v)\n {\n \treturn std::clamp(std::lround(v * 128), 0, 255);\n }\n \n+} /* namespace */\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::init\n */\n","prefixes":["1/3"]}