{"id":20269,"url":"https://patchwork.libcamera.org/api/1.1/patches/20269/?format=json","web_url":"https://patchwork.libcamera.org/patch/20269/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240611212101.14313-6-laurent.pinchart@ideasonboard.com>","date":"2024-06-11T21:21:00","name":"[5/6] ipa: rkisp1: goc: Avoid use of auto for short type","commit_ref":"5c08b179e425a8995462618a967229507293150b","pull_url":null,"state":"accepted","archived":false,"hash":"95294f78c130a055c895f71023babcfc4fd200f9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20269/mbox/","series":[{"id":4384,"url":"https://patchwork.libcamera.org/api/1.1/series/4384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4384","date":"2024-06-11T21:20:55","name":"ipa: rksip1: goc: Assorted fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20269/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20269/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DFE7C3237\n\tfor ;\n\tTue, 11 Jun 2024 21:21:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBA9965476;\n\tTue, 11 Jun 2024 23:21:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C193B6546F\n\tfor ;\n\tTue, 11 Jun 2024 23:21:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCE78A9A;\n\tTue, 11 Jun 2024 23:21:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RqgUz4OQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718140875;\n\tbh=00QeN9C7Th0maLzW4bhnqQwRkf48oDu3Fd5OFzPGLGg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RqgUz4OQi8EW8/vVg7WHZwxLocMTKenN2k0FEefwTK+KIBq8cmGXH6V2ABhWUzku+\n\tyMlUpblnBHN7tfn5ckJrJhO50MTBRNHfo8byi1AAYbDHbCwCYSgqBCUi3yjJis/UM6\n\tkeFceKkmYQOaJgBdnENfqfb7VfF2UArmIgklVfuc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 5/6] ipa: rkisp1: goc: Avoid use of auto for short type","Date":"Wed, 12 Jun 2024 00:21:00 +0300","Message-ID":"<20240611212101.14313-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace one occurrence of the auto type qualifier with the explicit type\nit represents to increase readability.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/goc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\nindex e98c9526722f..a82cee3bbf61 100644\n--- a/src/ipa/rkisp1/algorithms/goc.cpp\n+++ b/src/ipa/rkisp1/algorithms/goc.cpp\n@@ -112,7 +112,7 @@ void GammaOutCorrection::prepare(IPAContext &context,\n \t\t64, 64, 64, 64, 128, 128, 128, 128, 256,\n \t\t256, 256, 512, 512, 512, 512, 512, 0\n \t};\n-\tauto gamma_y = params->others.goc_config.gamma_y;\n+\t__u16 *gamma_y = params->others.goc_config.gamma_y;\n \n \tif (!frameContext.goc.update)\n \t\treturn;\n","prefixes":["5/6"]}