{"id":20222,"url":"https://patchwork.libcamera.org/api/1.1/patches/20222/?format=json","web_url":"https://patchwork.libcamera.org/patch/20222/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240606130102.2660-2-zachdecook@librem.one>","date":"2024-06-06T13:01:03","name":"build: Don't use non-posix arguments for build without GNU coreutils","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5790b03f6aafe7cafa93e4a719716549ae2d3d47","submitter":{"id":199,"url":"https://patchwork.libcamera.org/api/1.1/people/199/?format=json","name":"Zach DeCook","email":"zachdecook@librem.one"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20222/mbox/","series":[{"id":4369,"url":"https://patchwork.libcamera.org/api/1.1/series/4369/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4369","date":"2024-06-06T13:01:03","name":"build: Don't use non-posix arguments for build without GNU coreutils","version":1,"mbox":"https://patchwork.libcamera.org/series/4369/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20222/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20222/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 298E7C31E9\n\tfor ;\n\tThu, 6 Jun 2024 13:09:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35FA8634CA;\n\tThu, 6 Jun 2024 15:09:10 +0200 (CEST)","from mx1.librem.one (mx1.librem.one [138.201.176.93])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C5B2634CA\n\tfor ;\n\tThu, 6 Jun 2024 15:03:51 +0200 (CEST)","from smtp.librem.one (unknown [192.241.214.14])\n\tby mx1.librem.one (Postfix) with ESMTPS id A727081ED3\n\tfor ;\n\tThu, 6 Jun 2024 06:03:49 -0700 (PDT)"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=librem.one header.i=@librem.one\n\theader.b=\"qFyKrPUX\"; dkim-atps=neutral","name mx1.librem.one;\n\tdmarc=fail (p=reject dis=none) header.from=librem.one"],"From":"Zach DeCook ","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=librem.one; s=smtp;\n\tt=1717679028; bh=HcmfdMly2cdJFp5u4WY/SfSirzPb8k2dFNINbYxrfjA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qFyKrPUXht0mM7+61m5cp8X1OkUKNicqSwYm13lNrVFEafLBZ1ALzQTNCIjrS0FlP\n\thsQteDE7oG67A85NSDLhyEhcdRzYP4gVupwF8IyOcPTKJy33wnp3C7Q5gqHxNCYLcf\n\t1r+/IQDA2BLz2PHWFF5ig7sTuNxhx/M+kH6Xr3IMoi7/ura30Fvsy55FSDUu391TG+\n\tzpF7goDO3Ivbdr9MQ1cMkFu3hsqeGcS9OIiD//D++tIM8DbPhS7V9sKgXgXjR2J39I\n\tiNmgQl1jt6ragZYr+qj2bkh41E1CmNUFOhAKWia8ywBPczJTHJLmVvVRsRHcZYVSrV\n\tp7BuSbL84gODg==","To":"libcamera-devel@lists.libcamera.org","Cc":"Zach DeCook ","Subject":"[PATCH] build: Don't use non-posix arguments for build without GNU\n\tcoreutils","Date":"Thu, 6 Jun 2024 09:01:03 -0400","Message-ID":"<20240606130102.2660-2-zachdecook@librem.one>","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Thu, 06 Jun 2024 15:09:08 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"date will output a date like\n2024-06-05T17:06:30EDT\n\n(time zone is different than currently specified)\n\nln won't create a relative link\n(not a big deal because the command gets reran each time)\n---\nspecifically tested in Alpine Linux, using busybox utils\n src/py/libcamera/meson.build | 4 ++--\n utils/gen-version.sh | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 4807ca7d..524d010c 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -98,11 +98,11 @@ pycamera = shared_module('_libcamera',\n # Create symlinks from the build dir to the source dir so that we can use the\n # Python module directly from the build dir.\n \n-run_command('ln', '-fsrT', files('__init__.py'),\n+run_command('ln', '-fs', files('__init__.py'),\n meson.current_build_dir() / '__init__.py',\n check : true)\n \n-run_command('ln', '-fsrT', meson.current_source_dir() / 'utils',\n+run_command('ln', '-fs', meson.current_source_dir() / 'utils',\n meson.current_build_dir() / 'utils',\n check : true)\n \ndiff --git a/utils/gen-version.sh b/utils/gen-version.sh\nindex e1f7ca7b..1b818e9e 100755\n--- a/utils/gen-version.sh\n+++ b/utils/gen-version.sh\n@@ -42,7 +42,7 @@ if [ -z \"$build_dir\" ] || (echo \"$build_dir\" | grep -q \"$src_dir\")\n then\n \tgit update-index --refresh > /dev/null 2>&1\n fi\n-git diff-index --quiet HEAD || version=\"$version-dirty ($(date --iso-8601=seconds))\"\n+git diff-index --quiet HEAD || version=\"$version-dirty ($(date +%Y-%m-%dT%H:%M:%S%Z))\"\n \n # If a project version is provided, use it to replace the version number.\n if [ -n \"$project_version\" ]\n","prefixes":[]}