{"id":20206,"url":"https://patchwork.libcamera.org/api/1.1/patches/20206/?format=json","web_url":"https://patchwork.libcamera.org/patch/20206/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240605095417.157703-2-stefan.klug@ideasonboard.com>","date":"2024-06-05T09:53:49","name":"[v4,1/3] libcamera: Add gamma control id","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8c2942eb3bd3f6dbff3e33e08ec402c5e233c2c7","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20206/mbox/","series":[{"id":4363,"url":"https://patchwork.libcamera.org/api/1.1/series/4363/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4363","date":"2024-06-05T09:53:48","name":"libcamera: Add gamma control for rkisp1","version":4,"mbox":"https://patchwork.libcamera.org/series/4363/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20206/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20206/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BD40BDE6B\n\tfor ;\n\tWed, 5 Jun 2024 09:54:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D428565441;\n\tWed, 5 Jun 2024 11:54:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D7D5634B5\n\tfor ;\n\tWed, 5 Jun 2024 11:54:26 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:dcc4:f2dc:93ce:ff8f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 186E914B0;\n\tWed, 5 Jun 2024 11:54:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N0x3URwR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717581258;\n\tbh=GVPEBSdYs8x82qZeGmW5HxFXKVTXyuYiO+6i/L6OhHU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N0x3URwRQoUVhxTcC8uAlw45lKj0PbddLfENqSBwyvd6Dl68z+fGC0oYCnrFzjX5P\n\td7lh1Su4GMqa1EcWbXe3J4kQLj1Y7yH9piDKdmOavipyv2NAk5lgK0axjBlDhmNhA7\n\tYO/vdODu8EYuJVgWEqU8MexpgvR83Gn5QAwV+eBE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"[PATCH v4 1/3] libcamera: Add gamma control id","Date":"Wed, 5 Jun 2024 11:53:49 +0200","Message-ID":"<20240605095417.157703-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>","References":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A camera gamma of roughly 2.2 is necessary to produce correct output\nimages on a standard monitor. Add a control for that.\n\nFurther information is available here:\nhttps://en.wikipedia.org/wiki/SRGB\nhttps://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n\nSigned-off-by: Stefan Klug \nReviewed-by: Daniel Scally \nReviewed-by: Kieran Bingham \n---\n src/libcamera/control_ids_core.yaml | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex bf1f1a839f6a..303b0d32e020 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -243,6 +243,13 @@ controls:\n Specify a fixed contrast parameter. Normal contrast is given by the\n value 1.0; larger values produce images with more contrast.\n \n+ - Gamma:\n+ type: float\n+ description: |\n+ Specify a fixed gamma value. Default must be 2.2 which closely mimics \n+ sRGB gamma. Note that this is camera gamma, so it is applied as \n+ 1.0/gamma\n+\n - Lux:\n type: float\n description: |\n","prefixes":["v4","1/3"]}