{"id":20151,"url":"https://patchwork.libcamera.org/api/1.1/patches/20151/?format=json","web_url":"https://patchwork.libcamera.org/patch/20151/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240530171600.259495-6-hdegoede@redhat.com>","date":"2024-05-30T17:16:00","name":"[v2,5/5] libcamera: software_isp: Allow using dma-buffers from /dev/udmabuf","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4fcdee1078034dee3e0365a72481d032cf69ad73","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/1.1/people/102/?format=json","name":"Hans de Goede","email":"hdegoede@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20151/mbox/","series":[{"id":4341,"url":"https://patchwork.libcamera.org/api/1.1/series/4341/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4341","date":"2024-05-30T17:15:55","name":"libcamera: dma_buffer_allocator: Add support for using udmabuf to alloc dma-buffers","version":2,"mbox":"https://patchwork.libcamera.org/series/4341/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20151/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20151/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA0C7C32CF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 May 2024 17:16:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14D47634C2;\n\tThu, 30 May 2024 19:16:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 088EC634BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 May 2024 19:16:13 +0200 (CEST)","from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-331-1Y4J90ADOCyGQyN-w-IrbQ-1;\n\tThu, 30 May 2024 13:16:08 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4ED1F29AA387;\n\tThu, 30 May 2024 17:16:08 +0000 (UTC)","from shalem.redhat.com (unknown [10.39.192.43])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 61C4A286E;\n\tThu, 30 May 2024 17:16:07 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BeRWbrFb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1717089373;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ZQAsCdbMbChGG1yakvfGa0YJuSh3hBA9RiKk9IPanqg=;\n\tb=BeRWbrFbYTM2EkobLn4K+82og7TSfGZ9jGC7iSSz7VvRHpo5r056JFp64eVNzz6xIa8GBx\n\tydw7dZUaP2bLePxqvEjpHg6ozlFxvvD9x9inZq7o7reLNS4zoorWK8T0DbZ/D6M2e9wUJ5\n\t2WOowm9K4wyIB9cMLUO2xLFqgY/R0Xk=","X-MC-Unique":"1Y4J90ADOCyGQyN-w-IrbQ-1","From":"Hans de Goede <hdegoede@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Andrey Konovalov <andrey.konovalov.ynk@gmail.com>,\n\tPavel Machek <pavel@ucw.cz>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>, \n\tMilan Zamazal <mzamazal@redhat.com>, Maxime Ripard <mripard@redhat.com>, \n\tHans de Goede <hdegoede@redhat.com>","Subject":"[PATCH v2 5/5] libcamera: software_isp: Allow using dma-buffers from\n\t/dev/udmabuf","Date":"Thu, 30 May 2024 19:16:00 +0200","Message-ID":"<20240530171600.259495-6-hdegoede@redhat.com>","In-Reply-To":"<20240530171600.259495-1-hdegoede@redhat.com>","References":"<20240530171600.259495-1-hdegoede@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.5","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Allow the DmaBufAllocator used by the software ISP to use memfd() +\n/dev/udmabuf for the software ISP destination buffers.\n\nThis is useful on Linux distributions where normal users are not allowed\nto access /dev/dma_heap/* while they are allowed to access /dev/udmabuf.\n\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex b5eab670..8535db90 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -66,7 +66,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor)\n \t: debayerParams_{ DebayerParams::kGain10, DebayerParams::kGain10,\n \t\t\t  DebayerParams::kGain10, 0.5f, 0 },\n \t  dmaHeap_(DmaBufAllocator::DmaBufAllocatorFlag::CmaHeap |\n-\t\t   DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap)\n+\t\t   DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap |\n+\t\t   DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf)\n {\n \tif (!dmaHeap_.isValid()) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create DmaBufAllocator object\";\n","prefixes":["v2","5/5"]}