{"id":2013,"url":"https://patchwork.libcamera.org/api/1.1/patches/2013/?format=json","web_url":"https://patchwork.libcamera.org/patch/2013/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190924172503.30864-15-jacopo@jmondi.org>","date":"2019-09-24T17:24:56","name":"[libcamera-devel,14/21] test: serialization: Add V4L2ControlList serialization test","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f49310c5aa352407b14c789afc5a83819df02ec0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2013/mbox/","series":[{"id":506,"url":"https://patchwork.libcamera.org/api/1.1/series/506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=506","date":"2019-09-24T17:24:42","name":"Implement control serialization","version":1,"mbox":"https://patchwork.libcamera.org/series/506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2013/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2013/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B54A62378\n\tfor ;\n\tTue, 24 Sep 2019 19:23:37 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host89-248-dynamic.45-213-r.retail.telecomitalia.it [213.45.248.89])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2C82760006\n\tfor ;\n\tTue, 24 Sep 2019 17:23:36 +0000 (UTC)"],"X-Originating-IP":"213.45.248.89","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Sep 2019 19:24:56 +0200","Message-Id":"<20190924172503.30864-15-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190924172503.30864-1-jacopo@jmondi.org>","References":"<20190924172503.30864-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 14/21] test: serialization: Add\n\tV4L2ControlList serialization test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Sep 2019 17:23:37 -0000"},"content":"Add test to serialize and de-serialize a V4L2ControlList.\n\nSigned-off-by: Jacopo Mondi \n---\n test/serialization/meson.build | 1 +\n test/serialization/v4l2_control_list.cpp | 114 +++++++++++++++++++++++\n 2 files changed, 115 insertions(+)\n create mode 100644 test/serialization/v4l2_control_list.cpp","diff":"diff --git a/test/serialization/meson.build b/test/serialization/meson.build\nindex 510bd8c30d38..65ecdf2cf249 100644\n--- a/test/serialization/meson.build\n+++ b/test/serialization/meson.build\n@@ -1,6 +1,7 @@\n serialization_tests = [\n [ 'control_list', 'control_list.cpp' ],\n [ 'control_info_list', 'control_info_list.cpp' ],\n+ [ 'v4l2_control_list', 'v4l2_control_list.cpp' ],\n ]\n \n foreach t : serialization_tests\ndiff --git a/test/serialization/v4l2_control_list.cpp b/test/serialization/v4l2_control_list.cpp\nnew file mode 100644\nindex 000000000000..338ca4dadc78\n--- /dev/null\n+++ b/test/serialization/v4l2_control_list.cpp\n@@ -0,0 +1,114 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * v4l2_control_list.cpp - Serialize and de-serialize a list of v4l2 controls\n+ */\n+\n+#include \n+\n+#include \n+#include \n+#include \n+\n+#include \"test.h\"\n+#include \"serializer.h\"\n+#include \"serialization_test.h\"\n+#include \"v4l2_controls.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class V4L2ControlListSerializeTest : public SerializationTest\n+{\n+private:\n+\tvoid initializeValidationMatrix()\n+\t{\n+\t\tvalueValidationMatrix[0][0] = V4L2_CID_SATURATION;\n+\t\tvalueValidationMatrix[0][1] = DataTypeInteger;\n+\t\tvalueValidationMatrix[0][2] = 8;\n+\t\tvalueValidationMatrix[0][3] = 50;\n+\t\tvalueValidationMatrix[0][4] = false;\n+\t\tvalueValidationMatrix[1][0] = V4L2_CID_CONTRAST;\n+\t\tvalueValidationMatrix[1][1] = DataTypeInteger;\n+\t\tvalueValidationMatrix[1][2] = 8;\n+\t\tvalueValidationMatrix[1][3] = 128;\n+\t\tvalueValidationMatrix[1][4] = false;\n+\t\tvalueValidationMatrix[2][0] = V4L2_CID_BRIGHTNESS;\n+\t\tvalueValidationMatrix[2][1] = DataTypeInteger;\n+\t\tvalueValidationMatrix[2][2] = 8;\n+\t\tvalueValidationMatrix[2][3] = 255;\n+\t\tvalueValidationMatrix[2][4] = false;\n+\n+\t\tnumCtrls_ = 3;\n+\t}\n+\n+\tint init()\n+\t{\n+\t\tint ret = SerializationTest::init();\n+\t\tif (ret != TestPass)\n+\t\t\treturn ret;\n+\n+\t\tret = initSubdevice();\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tV4L2ControlList controls;\n+\n+\t\tcontrols.add(V4L2_CID_BRIGHTNESS, 255);\n+\t\tcontrols.add(V4L2_CID_CONTRAST, 128);\n+\t\tcontrols.add(V4L2_CID_SATURATION, 50);\n+\n+\t\tint ret = sensor_->setControls(&controls);\n+\t\tif (ret) {\n+\t\t\tcerr << \"Failed to set controls\" << endl;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\tinitializeValidationMatrix();\n+\n+\t\t/* Serialize and verify the produced blob size. */\n+\t\tstd::unique_ptr blob = controls.serialize();\n+\t\tif (!blob) {\n+\t\t\tcerr << \"Failed to serialize the control list\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tret = validateValueBlobSize(blob.get());\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\t/* Validate each serialized data value. */\n+\t\tuint8_t *b = blob->data();\n+\t\tfor (unsigned int i = 0; i < numCtrls_; ++i) {\n+\t\t\tif (!validateValueBlob(b))\n+\t\t\t\treturn TestFail;\n+\n+\t\t\tb += VALUE_BLOB_SIZE;\n+\t\t}\n+\n+\t\t/* De-serialize a control list and re-validate it. */\n+\t\tV4L2ControlList newList;\n+\t\tnewList.deserialize(blob->data(), blob->size());\n+\t\tfor (auto it : newList) {\n+\t\t\tif (!validateDataValue(it.id(), it))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Does it still work when re-applied to a subdevice? */\n+\t\tret = sensor_->setControls(&newList);\n+\t\tif (ret) {\n+\t\t\tcerr << \"Failed to set controls\" << endl;\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(V4L2ControlListSerializeTest)\n","prefixes":["libcamera-devel","14/21"]}