{"id":20105,"url":"https://patchwork.libcamera.org/api/1.1/patches/20105/?format=json","web_url":"https://patchwork.libcamera.org/patch/20105/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240527174016.11415-3-laurent.pinchart@ideasonboard.com>","date":"2024-05-27T17:40:16","name":"[CI,2/2] Add compilation test with gcc 14","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"281fe5f3e3cbed4a2bc715efe51e26afd14d0652","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20105/mbox/","series":[{"id":4329,"url":"https://patchwork.libcamera.org/api/1.1/series/4329/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4329","date":"2024-05-27T17:40:14","name":"Miscellaneous CI coverage extensions","version":1,"mbox":"https://patchwork.libcamera.org/series/4329/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20105/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20105/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E47B5BDE6B\n\tfor ;\n\tMon, 27 May 2024 17:40:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89750634AF;\n\tMon, 27 May 2024 19:40:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24986634AF\n\tfor ;\n\tMon, 27 May 2024 19:40:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEC801586\n\tfor ;\n\tMon, 27 May 2024 19:40:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"piCFruGR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716831628;\n\tbh=5+B0kvQKsWVlfQTrMuMrCLbYg1P/Az1s5cdCKKaMBOU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=piCFruGRbcYbK9CX+qNOw+lFVsggoOCYn+Hiy3LaCxNpR6d6plHDg7QHMjGr8c4iQ\n\trg4zWcdkB364KPWY8Erfax0X+EjdgTfm4xSTTQzP6G/f/HblKmkHIlp87sUz5iVDqh\n\t0uVA112U0gUvZp5pj8dcCUGlh5v2I78GHmA5zu/E=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[CI] [PATCH 2/2] Add compilation test with gcc 14","Date":"Mon, 27 May 2024 20:40:16 +0300","Message-ID":"<20240527174016.11415-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.1","In-Reply-To":"<20240527174016.11415-1-laurent.pinchart@ideasonboard.com>","References":"<20240527174016.11415-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Compile with gcc 14 on Debian trixie. Compiling with C++20 would trigger\nthe following warning, introduced in gcc 14:\n\n../src/libcamera/base/log.cpp: In member function ‘void libcamera::Logger::write(const libcamera::LogMessage&)’:\n../src/libcamera/base/log.cpp:468:61: error: ‘std::shared_ptr<_Tp> std::atomic_load(const shared_ptr<_Tp>*) [with _Tp = libcamera::LogOutput]’ is deprecated: use 'std::atomic>' instead [-Werror=deprecated-declarations]\n 468 | std::shared_ptr output = std::atomic_load(&output_);\n | ~~~~~~~~~~~~~~~~^~~~~~~~~~\nIn file included from /usr/include/c++/14/memory:81,\n from ../include/libcamera/base/class.h:10,\n from ../include/libcamera/base/log.h:15,\n from ../src/libcamera/base/log.cpp:8:\n/usr/include/c++/14/bits/shared_ptr_atomic.h:142:5: note: declared here\n 142 | atomic_load(const shared_ptr<_Tp>* __p)\n | ^~~~~~~~~~~\n\nAs std::atomic> got introduced in C++20, we can't use\nit while remaining compatible with C++17. Disabling the\n-Werror=deprecated-declarations option would prevent other deprecated\ndeclarations from being noticed, so it's not a good solution either.\n\nTo work around the problem, use C++17 when compiling with gcc 14. gcc 13\nstill gives us decent test coverage of C++20 compilation.\n\nSigned-off-by: Laurent Pinchart \n---\n .gitlab-ci/setup-container.sh | 12 +++++++++---\n gitlab-ci.yml | 20 ++++++++++++--------\n 2 files changed, 21 insertions(+), 11 deletions(-)","diff":"diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\nindex fc3c0568bf7c..93a9f9cc91e8 100755\n--- a/.gitlab-ci/setup-container.sh\n+++ b/.gitlab-ci/setup-container.sh\n@@ -93,10 +93,16 @@ archs=( amd64 )\n \n declare -A components\n \n-# On Debian bullseye, install gcc 9 in addition to the default gcc 10.\n-if [[ $FDO_DISTRIBUTION_VERSION == 'bullseye' ]] ; then\n+# Install additional gcc versions On Debian bullseye (gcc 9) and trixie (gcc\n+# 14).\n+case $FDO_DISTRIBUTION_VERSION in\n+'bullseye')\n \tPKGS_LIBCAMERA_RUNTIME+=( g++-9 )\n-fi\n+\t;;\n+'trixie')\n+\tPKGS_LIBCAMERA_RUNTIME+=( g++-14 )\n+\t;;\n+esac\n \n # We use Debian bookworm containers to produce ARM binaries and run unit tests\n # with virtme, and other Debian versions for compilation-testing on amd64 only.\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex 465931a761fc..50b81e591458 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -69,7 +69,7 @@ include:\n .libcamera-ci.debian:13:\n variables:\n FDO_DISTRIBUTION_VERSION: 'trixie'\n- FDO_DISTRIBUTION_TAG: '2024-05-27.0'\n+ FDO_DISTRIBUTION_TAG: '2024-05-27.1'\n \n .container-debian:\n extends:\n@@ -219,13 +219,17 @@ build-full:debian:13:\n needs:\n - job: container-debian:13\n artifacts: false\n- variables:\n- ARCH: amd64\n- CC: gcc-13\n- CXX: g++-13\n- MESON_OPTIONS: >-\n- ${MESON_ALL_OPTIONS}\n- -D cpp_std=c++20\n+ parallel:\n+ matrix:\n+ - ARCH: amd64\n+ CC: gcc-13\n+ CXX: g++-13\n+ MESON_OPTIONS: >-\n+ ${MESON_ALL_OPTIONS}\n+ -D cpp_std=c++20\n+ - ARCH: amd64\n+ CC: gcc-14\n+ CXX: g++-14\n \n # Build each commit in the branch individually to detect compilation breakages.\n build-history:\n","prefixes":["CI","2/2"]}