{"id":2010,"url":"https://patchwork.libcamera.org/api/1.1/patches/2010/?format=json","web_url":"https://patchwork.libcamera.org/patch/2010/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190924172503.30864-12-jacopo@jmondi.org>","date":"2019-09-24T17:24:53","name":"[libcamera-devel,11/21] libcamera: controls: Remove explicit from ControlInfo constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6ff75770cddc189dc32de31798ba264e10361099","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2010/mbox/","series":[{"id":506,"url":"https://patchwork.libcamera.org/api/1.1/series/506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=506","date":"2019-09-24T17:24:42","name":"Implement control serialization","version":1,"mbox":"https://patchwork.libcamera.org/series/506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2010/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2010/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F14B6238D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2019 19:23:35 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host89-248-dynamic.45-213-r.retail.telecomitalia.it [213.45.248.89])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 0471260006\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2019 17:23:34 +0000 (UTC)"],"X-Originating-IP":"213.45.248.89","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Sep 2019 19:24:53 +0200","Message-Id":"<20190924172503.30864-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190924172503.30864-1-jacopo@jmondi.org>","References":"<20190924172503.30864-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 11/21] libcamera: controls: Remove\n\texplicit from ControlInfo constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 24 Sep 2019 17:23:35 -0000"},"content":"With more than one argument, no need for explicit keyword.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex a5b5f245ef60..0aeb01927584 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -30,7 +30,7 @@ struct ControlMetadata {\n class ControlInfo : public DataInfo\n {\n public:\n-\texplicit ControlInfo(ControlId id, const DataValue &min = 0,\n+\tControlInfo(ControlId id, const DataValue &min = 0,\n \t\t\t     const DataValue &max = 0);\n \tControlId id() const { return meta_->id; }\n \tconst char *name() const { return meta_->name; }\n","prefixes":["libcamera-devel","11/21"]}