{"id":20021,"url":"https://patchwork.libcamera.org/api/1.1/patches/20021/?format=json","web_url":"https://patchwork.libcamera.org/patch/20021/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240508145131.1452305-1-paul.elder@ideasonboard.com>","date":"2024-05-08T14:51:31","name":"pipeline: rkisp1: rkisp1_source: Minor fixes for clang 17","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"87b44c4a3aa720b640a2668b9bb76e0c7ca0be5f","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20021/mbox/","series":[{"id":4296,"url":"https://patchwork.libcamera.org/api/1.1/series/4296/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4296","date":"2024-05-08T14:51:31","name":"pipeline: rkisp1: rkisp1_source: Minor fixes for clang 17","version":1,"mbox":"https://patchwork.libcamera.org/series/4296/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20021/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20021/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2496ABDE6B\n\tfor ;\n\tWed, 8 May 2024 14:51:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A26661A73;\n\tWed, 8 May 2024 16:51:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F72761A73\n\tfor ;\n\tWed, 8 May 2024 16:51:42 +0200 (CEST)","from neptunite.hamster-moth.ts.net\n\t(h175-177-049-156.catv02.itscom.jp [175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 780D0B0B;\n\tWed, 8 May 2024 16:51:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d/9Yp7Xv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715179899;\n\tbh=SsILR4AIOk1YmZQgwKxH2pr699nwS5GMLQSDKKWCNGc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=d/9Yp7XvX7PD+1nmGUQ+a2NQC98XvsLWfQzpn4yZlR68U3LKvu7PMAm0JnwQWGiwS\n\twwwHQ08oJvBQErfKiv1AQUCPJWygCSls2UyzThsGu9DGGDF8RTPWvC+4JV9AL/yeSw\n\t7QiSOT3f1PlgnhLHIr5b3kDsG/wWmPO8Sw3s06u4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang 17","Date":"Wed, 8 May 2024 23:51:31 +0900","Message-Id":"<20240508145131.1452305-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Remove a stray semicolon and fix the declaration of V4L2SubdeviceFormat\nfrom class to struct as it should be, to fix compilation errors on clang\n17.\n\nSigned-off-by: Paul Elder \n---\n src/libcamera/pipeline/rkisp1/rkisp1_source.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_source.h b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\nindex 5a49e9d3..67bc287f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n@@ -24,7 +24,7 @@ class DelayedControls;\n class MediaEntity;\n class SensorConfiguration;\n class V4L2Subdevice;\n-class V4L2SubdeviceFormat;\n+struct V4L2SubdeviceFormat;\n \n class RkISP1Source\n {\n@@ -35,7 +35,7 @@ public:\n \tint init();\n \tstd::unique_ptr initDelayedControls();\n \n-\tbool isTPG() const { return !!tpg_; };\n+\tbool isTPG() const { return !!tpg_; }\n \n \tconst std::string &model() const { return model_; }\n \tconst std::string &id() const { return id_; }\n","prefixes":[]}