{"id":20012,"url":"https://patchwork.libcamera.org/api/1.1/patches/20012/?format=json","web_url":"https://patchwork.libcamera.org/patch/20012/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240508080401.14850-2-naush@raspberrypi.com>","date":"2024-05-08T08:03:56","name":"[v2,1/6] libcamera: formats: Add RGB48 formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7e81882a72b9b6d07efb9a40b60f69e818b8e160","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20012/mbox/","series":[{"id":4293,"url":"https://patchwork.libcamera.org/api/1.1/series/4293/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4293","date":"2024-05-08T08:03:55","name":"Pre Raspberry Pi 5 support changes","version":2,"mbox":"https://patchwork.libcamera.org/series/4293/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20012/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20012/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8ADEBDE6B\n\tfor ;\n\tWed, 8 May 2024 08:04:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E51766343B;\n\tWed, 8 May 2024 10:04:04 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39B7A6342A\n\tfor ;\n\tWed, 8 May 2024 10:04:01 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-41bca450fa3so25960805e9.2\n\tfor ;\n\tWed, 08 May 2024 01:04:01 -0700 (PDT)","from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw16-20020a05600c475000b0041c14061c71sm1351944wmo.15.2024.05.08.01.04.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 May 2024 01:04:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"B4XkqaVr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715155440; x=1715760240;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=oPpBfzgcOt84SvUYH5rr6nfm4TxLEN8TNbvq4qlFgLs=;\n\tb=B4XkqaVrtnnK8fyKVRDMh33i/kTLfZq2ezcdPCoEVT70t8Ai6L9DXT7VkyEzAYfcfQ\n\tzuCRWS7I5BXU6JJh9F4ck0xMrr7nTKuLYrpZbkruyqtn0mL/q1+nXj9hFzL9rgw2g1r0\n\t7fvUCYHqF6emLj1Jl1JUFGsdcOqTzqFvibdoWtMMKygBIM0i5T8R7oPnNcZ0nmmXVVYY\n\tazpYqjnD0zPUmNVAOFAODj5WnratOmMQaaUmuMjwQdJA8mJAvugWD9uGla3HeRa5rtWI\n\tf4RrHKViDqt6/MWpzjHvT6gdppEd8wOvC1CJzB1Zdyg4Dxa9MmsuOWMKM6taFZDca9g2\n\tCsAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715155440; x=1715760240;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=oPpBfzgcOt84SvUYH5rr6nfm4TxLEN8TNbvq4qlFgLs=;\n\tb=olNVYgG2rTVVZ/kZ+EAunSeGOS43AgRgG9azkdVByvHp9eLDIuRrRKOsYkkVmnIOlc\n\t2D4LR3tKpIyJJ1HvG3p0lcXhzw+z7Uh9sLJzqZdC3LvoC2v2xucUBXF89dHDJ3mfzDC6\n\tLT2sujAQiKU45eSmZ+NzuXMwdam/ERdxPhi9+GwLImL6lagyC3fC4GMyjP7rk1HaQiDs\n\tOkKoQhDEjGmLQMafK110ngrF5R0wHjW+EJRNy4mzbcQZ5iU6A+JrtP4zIti1yWfenJPi\n\t3q4xmsCCv5+Z9gCuz2f0umXF6PIy3EgkzeTsSa6f34lbRLj7qat7W6K15G2q9moLUCev\n\tor8Q==","X-Gm-Message-State":"AOJu0YwBh1nf/DqfXs1s2C8HXcOfGHCimvGM9ZEUaK1M8AkqrFmvpRzA\n\tAbDqbFm7hChXi9cc3m9fC9eY+6P1ui/fSu8YOSDl4n51b1bw2komd2d/H1jWK0bbbX6vRLlqk5B\n\tD","X-Google-Smtp-Source":"AGHT+IHmFjbl03atCaVWAB600hkG1LEup/qRawzg+VyCpXgnpG6wU3v8PTZAmRnw9/3bqRvJe9Fh8Q==","X-Received":"by 2002:a05:600c:3555:b0:41a:7ab1:fd98 with SMTP id\n\t5b1f17b1804b1-41f71ebf886mr13144645e9.21.1715155440543; \n\tWed, 08 May 2024 01:04:00 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v2 1/6] libcamera: formats: Add RGB48 formats","Date":"Wed, 8 May 2024 09:03:56 +0100","Message-Id":"<20240508080401.14850-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240508080401.14850-1-naush@raspberrypi.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add support for 16-bps (48-bpp) RGB output formats. These new formats\nare define for the RGB and BGR ordering.\n\nSigned-off-by: Naushir Patuck \n---\n include/linux/drm_fourcc.h | 4 ++++\n include/linux/videodev2.h | 2 ++\n src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n src/libcamera/formats.yaml | 5 +++++\n src/libcamera/v4l2_pixelformat.cpp | 4 ++++\n 5 files changed, 35 insertions(+)","diff":"diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\nindex d6c83d9c49f4..5133a6551a34 100644\n--- a/include/linux/drm_fourcc.h\n+++ b/include/linux/drm_fourcc.h\n@@ -210,6 +210,10 @@ extern \"C\" {\n #define DRM_FORMAT_RGBA1010102\tfourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n #define DRM_FORMAT_BGRA1010102\tfourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n \n+/* 48 bpp RGB */\n+#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n+#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n+\n /* 64 bpp RGB */\n #define DRM_FORMAT_XRGB16161616\tfourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n #define DRM_FORMAT_XBGR16161616\tfourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */\ndiff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\nindex 7e556911c9e1..4fdd91494041 100644\n--- a/include/linux/videodev2.h\n+++ b/include/linux/videodev2.h\n@@ -555,6 +555,8 @@ struct v4l2_pix_format {\n \n /* RGB formats (6 or 8 bytes per pixel) */\n #define V4L2_PIX_FMT_BGR48_12 v4l2_fourcc('B', '3', '1', '2') /* 48 BGR 12-bit per component */\n+#define V4L2_PIX_FMT_BGR48 v4l2_fourcc('B', 'G', 'R', '6') /* 48 BGR 16-bit per component */\n+#define V4L2_PIX_FMT_RGB48 v4l2_fourcc('R', 'G', 'B', '6') /* 48 RGB 16-bit per component */\n #define V4L2_PIX_FMT_ABGR64_12 v4l2_fourcc('B', '4', '1', '2') /* 64 BGRA 12-bit per component */\n \n /* Grey formats */\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 955c3fba8b8d..21a7719e84c4 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -270,6 +270,26 @@ const std::map pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::BGR161616, {\n+\t\t.name = \"BGR161616\",\n+\t\t.format = formats::BGR161616,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_RGB48), },\n+\t\t.bitsPerPixel = 48,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::RGB161616, {\n+\t\t.name = \"RGB161616\",\n+\t\t.format = formats::RGB161616,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_BGR48), },\n+\t\t.bitsPerPixel = 48,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \n \t/* YUV packed formats. */\n \t{ formats::YUYV, {\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex d8a379923b56..bde2cc803b98 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -43,6 +43,11 @@ formats:\n - BGRA8888:\n fourcc: DRM_FORMAT_BGRA8888\n \n+ - RGB161616:\n+ fourcc: DRM_FORMAT_RGB161616\n+ - BGR161616:\n+ fourcc: DRM_FORMAT_BGR161616\n+\n - YUYV:\n fourcc: DRM_FORMAT_YUYV\n - YVYU:\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 731dc10f1d73..efb6f2940235 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -71,6 +71,10 @@ const std::map vpf2pf{\n \t\t{ formats::BGRA8888, \"32-bit ARGB 8-8-8-8\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGRA32),\n \t\t{ formats::RGBA8888, \"32-bit ABGR 8-8-8-8\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB48),\n+\t\t{ formats::BGR161616, \"48-bit RGB 16-16-16\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR48),\n+\t\t{ formats::RGB161616, \"48-bit BGR 16-16-16\" } },\n \n \t/* YUV packed formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUYV),\n","prefixes":["v2","1/6"]}