{"id":19994,"url":"https://patchwork.libcamera.org/api/1.1/patches/19994/?format=json","web_url":"https://patchwork.libcamera.org/patch/19994/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","date":"2024-05-03T02:52:04","name":"[3/4] apps: qcam: Use standard key sequence for quit action","commit_ref":"4885f2d70d71f92d505cb33738dd592727cd036c","pull_url":null,"state":"accepted","archived":false,"hash":"bcbd25c119b75e1af6acca554a5d82eaf901cda0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19994/mbox/","series":[{"id":4285,"url":"https://patchwork.libcamera.org/api/1.1/series/4285/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4285","date":"2024-05-03T02:52:01","name":"libcamera: Assorted cleanups and fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4285/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19994/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19994/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05F9BC328F\n\tfor ;\n\tFri, 3 May 2024 02:52:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96B6A63416;\n\tFri, 3 May 2024 04:52:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F02863416\n\tfor ;\n\tFri, 3 May 2024 04:52:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97B333A3\n\tfor ;\n\tFri, 3 May 2024 04:51:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AY1mib/W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714704678;\n\tbh=yG/mpPBalZzvYCR8lb7+bQDMtyzLwEyxZOHAJx4tggs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=AY1mib/WeY7mKGMAe8xScEb7LCiscxAWayHii1u3GpsjqLo40GOQ+tweMNogtnSN3\n\tBytIGJl8UI1sHXxBUsaxKsTS3VCVnwa8zy9zQ8zUIivb33LMRM5TMYC/+c8bqSS7ba\n\tty/7nU8Pg778Z/v5K+aJ3SShM6Qg6hOq/OJjgoR4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 3/4] apps: qcam: Use standard key sequence for quit action","Date":"Fri, 3 May 2024 05:52:04 +0300","Message-ID":"<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","In-Reply-To":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the manual CTRL+Q key sequence with QKeySequence::Quit. This\nautomatically maps to the native shortcut for the quit action,\nregardless of the platform. Even though we don't expect qcam to run on\nnon-Linux platform, using a QKeySequence is still a good practice when\none exists.\n\nThis doesn't change qcam's behaviour, as the native quit key sequence is\nCTRL+Q on Linux systems.\n\nSigned-off-by: Laurent Pinchart \n---\n src/apps/qcam/main_window.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex 0f16c038d516..361d582532d5 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -190,7 +190,7 @@ int MainWindow::createToolbars()\n \taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n \t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n \t\t\t\t \"Quit\");\n-\taction->setShortcut(Qt::CTRL | Qt::Key_Q);\n+\taction->setShortcut(QKeySequence::Quit);\n \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n \n \t/* Camera selector. */\n","prefixes":["3/4"]}