{"id":19992,"url":"https://patchwork.libcamera.org/api/1.1/patches/19992/?format=json","web_url":"https://patchwork.libcamera.org/patch/19992/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","date":"2024-05-03T02:52:02","name":"[1/4] libcamera: utils: Avoid infinite recursion with strtod()","commit_ref":"e0318c4776549a0db0a06682e906310970c8caf9","pull_url":null,"state":"accepted","archived":false,"hash":"8d98549688de911adec1dd39af6041e73fd1d0a4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19992/mbox/","series":[{"id":4285,"url":"https://patchwork.libcamera.org/api/1.1/series/4285/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4285","date":"2024-05-03T02:52:01","name":"libcamera: Assorted cleanups and fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4285/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19992/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19992/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFF9CC328F\n\tfor ;\n\tFri, 3 May 2024 02:52:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F00F6340B;\n\tFri, 3 May 2024 04:52:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33C626341A\n\tfor ;\n\tFri, 3 May 2024 04:52:14 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D079E3A3\n\tfor ;\n\tFri, 3 May 2024 04:51:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KVUra0bQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714704676;\n\tbh=I0jKV3ql9fIdXigKZR1o5tB91xRbqDt7ytaH9cYvNj8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=KVUra0bQPLXI4lNYs9JP57WUVMR8DBX8j/IAOol9TzTErh28jsZcy1K/OlMNCGoyo\n\tb+XjqjwnTJEh+XZyH3hCQ4/2psUbMjjdrN3N4vRc9mPTzaNoWIPLKdFakzugSz4op8\n\tNOcQavl/gVo84Svj4XlQgch0LP524X0OpB5cL338=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 1/4] libcamera: utils: Avoid infinite recursion with strtod()","Date":"Fri, 3 May 2024 05:52:02 +0300","Message-ID":"<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","In-Reply-To":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the C library doesn't provide local object support, the\nutils::strtod() function simply calls strtod() from the C library. The\ncurrent implementation does so incorrectly, and calls utils::strtod()\ninstead, resulting in infinite recursion. Fix it with a proper namespace\nqualifier.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/base/utils.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\nindex 2f4c3177ac13..96023f992e03 100644\n--- a/src/libcamera/base/utils.cpp\n+++ b/src/libcamera/base/utils.cpp\n@@ -517,7 +517,7 @@ double strtod(const char *__restrict nptr, char **__restrict endptr)\n \t * If the libc implementation doesn't provide locale object support,\n \t * assume that strtod() is locale-independent.\n \t */\n-\treturn strtod(nptr, endptr);\n+\treturn ::strtod(nptr, endptr);\n #endif\n }\n \n","prefixes":["1/4"]}