{"id":19947,"url":"https://patchwork.libcamera.org/api/1.1/patches/19947/?format=json","web_url":"https://patchwork.libcamera.org/patch/19947/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240424234224.9658-3-laurent.pinchart@ideasonboard.com>","date":"2024-04-24T23:42:20","name":"[v1,2/6] test: fence: Turn class member variable into local variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b41b3fbfd22fca8160f9766aa89f7db106583eb8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19947/mbox/","series":[{"id":4271,"url":"https://patchwork.libcamera.org/api/1.1/series/4271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4271","date":"2024-04-24T23:42:18","name":"vimc scaling improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/4271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19947/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19947/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 954AFC3200\n\tfor ;\n\tWed, 24 Apr 2024 23:42:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEA19633FB;\n\tThu, 25 Apr 2024 01:42:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECB7861A94\n\tfor ;\n\tThu, 25 Apr 2024 01:42:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3EE2B1\n\tfor ;\n\tThu, 25 Apr 2024 01:41:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ba37gPqE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714002100;\n\tbh=+UX0BOvEyE9vdmhREGzttYT+/eC/61yXaL1AdtqIfZ0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ba37gPqEfkjewX0evWolvWTtM/1XI668dvVn8AhR1wB64LJ8ujXGxxxovZwTACYV1\n\t71+JSM7PoVwIf1FjCddbuPH33y6MySsoOX3aMIf2BwhUMr5euVwHvA+KZFJEX1HlLQ\n\trLbMfTbSgC5zeqB8D0YIqWVT3KR4M7u3TI5Xu+Ec=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1 2/6] test: fence: Turn class member variable into local\n\tvariable","Date":"Thu, 25 Apr 2024 02:42:20 +0300","Message-ID":"<20240424234224.9658-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","In-Reply-To":"<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>","References":"<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The fence_ class member variable is only used locally in the\nFenceTest::run() function. Make it a local variable.\n\nSigned-off-by: Laurent Pinchart \n---\n test/fence.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/test/fence.cpp b/test/fence.cpp\nindex 1e38bc2f8790..e6f79d2faa21 100644\n--- a/test/fence.cpp\n+++ b/test/fence.cpp\n@@ -43,7 +43,6 @@ private:\n \n \tvoid signalFence();\n \n-\tstd::unique_ptr fence_;\n \tEventDispatcher *dispatcher_;\n \tUniqueFD eventFd_;\n \tUniqueFD eventFd2_;\n@@ -274,13 +273,14 @@ int FenceTest::run()\n \t\tint ret;\n \t\tif (i == expiredRequestId_) {\n \t\t\t/* This request will have a fence, and it will expire. */\n-\t\t\tfence_ = std::make_unique(std::move(eventFd_));\n-\t\t\tif (!fence_->isValid()) {\n+\t\t\tstd::unique_ptr fence =\n+\t\t\t\tstd::make_unique(std::move(eventFd_));\n+\t\t\tif (!fence->isValid()) {\n \t\t\t\tcerr << \"Fence should be valid\" << endl;\n \t\t\t\treturn TestFail;\n \t\t\t}\n \n-\t\t\tret = request->addBuffer(stream_, buffer.get(), std::move(fence_));\n+\t\t\tret = request->addBuffer(stream_, buffer.get(), std::move(fence));\n \t\t} else {\n \t\t\t/* All other requests will have no Fence. */\n \t\t\tret = request->addBuffer(stream_, buffer.get());\n","prefixes":["v1","2/6"]}