{"id":19909,"url":"https://patchwork.libcamera.org/api/1.1/patches/19909/?format=json","web_url":"https://patchwork.libcamera.org/patch/19909/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240419055849.1086196-1-paul.elder@ideasonboard.com>","date":"2024-04-19T05:58:49","name":"[v2] ipa: rkisp1: agc: Fix histogram construction","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3e9a727dd74d515481d36a2a88c4621f39967f0b","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19909/mbox/","series":[{"id":4264,"url":"https://patchwork.libcamera.org/api/1.1/series/4264/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4264","date":"2024-04-19T05:58:49","name":"[v2] ipa: rkisp1: agc: Fix histogram construction","version":2,"mbox":"https://patchwork.libcamera.org/series/4264/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19909/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19909/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52C5BBE08B\n\tfor ;\n\tFri, 19 Apr 2024 05:59:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DDD5633EE;\n\tFri, 19 Apr 2024 07:59:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E432E633ED\n\tfor ;\n\tFri, 19 Apr 2024 07:59:00 +0200 (CEST)","from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F876827;\n\tFri, 19 Apr 2024 07:58:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lJI6LnWH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713506292;\n\tbh=iarPo9S3bA3OgStjoO+Ax1O065cvvo0+dtpAugwfpP8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=lJI6LnWHmZwD/69qT3o+i8iBYDAFfWaBkSMXPE5HvdNsfpgY18+ps/YnDLamFMziP\n\t8gAs12ZmkLhCESsYgfzA8Ro5RObP4CS/4CtfrtjsnwxjkI6UGbAXRaj9s0ieJi59vt\n\tj7AeykTtkbpFeSjUXpU2cWJfSoAllt9LL4H4HDgc=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH v2] ipa: rkisp1: agc: Fix histogram construction","Date":"Fri, 19 Apr 2024 14:58:49 +0900","Message-Id":"<20240419055849.1086196-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This histogram reported by the rkisp1 hardware is 20 bits, where the\nupper 16 bits are meaningful integer data and the lower 4 bits are\nfractional and meant to be discarded. Remove thse 4 bits when\nconstruction the histogram.\n\nSigned-off-by: Paul Elder \n\n---\nThis was meant to be in the same series as \"[PATCH v2] ipa: libipa:\nhistogram: Add transform parameter to constructor\"\n\nThis depends on v2 of \"Centralise Agc into libipa\".\n\nChanges in v2:\n- use a lambda function instead of the rshift parameter\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 27b6f2c1..26526f5e 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -278,7 +278,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \tconst rkisp1_cif_isp_stat *params = &stats->params;\n \tASSERT(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP);\n \n-\tHistogram hist({ params->hist.hist_bins, context.hw->numHistogramBins });\n+\tHistogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n+\t\t [](uint32_t x) { return x >> 4; });\n \texpMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n \n \t/*\n","prefixes":["v2"]}