{"id":19840,"url":"https://patchwork.libcamera.org/api/1.1/patches/19840/?format=json","web_url":"https://patchwork.libcamera.org/patch/19840/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240404145649.24039-1-laurent.pinchart@ideasonboard.com>","date":"2024-04-04T14:56:49","name":"media: v4l2-subdev: Clearly document that the crop API won't be extended","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"2b3617e8712c31ce557d59e271519ffeaf2dd18f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19840/mbox/","series":[{"id":4248,"url":"https://patchwork.libcamera.org/api/1.1/series/4248/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4248","date":"2024-04-04T14:56:49","name":"media: v4l2-subdev: Clearly document that the crop API won't be extended","version":1,"mbox":"https://patchwork.libcamera.org/series/4248/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19840/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19840/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55892C0DA4\n\tfor ;\n\tThu, 4 Apr 2024 14:57:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 858F66337D;\n\tThu, 4 Apr 2024 16:57:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD5446337B\n\tfor ;\n\tThu, 4 Apr 2024 16:57:01 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 808321A2;\n\tThu, 4 Apr 2024 16:56:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aXRsLu/o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712242583;\n\tbh=jxA4EI/SVx+j0LPaiiQXtf0KMwX6/VTC9bpwVxEQIRM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=aXRsLu/oe8wp0NduW8nkem+vYCR4UYHXLlk5BD0wofQ9f28A76YY3U/vLQ+LH7Agk\n\t/4aNcuILog59g09FvsOIQ3nnjQTacVUph6FMvPqCmyjNrLTtpEgi2UTOhVKRbwiX6Q\n\t3Zm4IJlULxAr9T8tp6NsVGHnrxEAVj/k0FwSBS3s=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans Verkuil ,\n\tTomi Valkeinen ,\n\tSakari Ailus ","Subject":"[PATCH] media: v4l2-subdev: Clearly document that the crop API won't\n\tbe extended","Date":"Thu, 4 Apr 2024 17:56:49 +0300","Message-ID":"<20240404145649.24039-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2 subdev crop API has been marked as obsolete, deprecated by the\nselection API. Despite this, it has recently been extended with streams\nsupport. In hindsight this was a mistake. Make sure it doesn't happen\nagain by clearly documenting that no new extensions will be accepted.\n\nSuggested-by: Hans Verkuil \nSigned-off-by: Laurent Pinchart \n---\n .../userspace-api/media/v4l/vidioc-subdev-g-crop.rst | 6 +++---\n include/uapi/linux/v4l2-subdev.h | 4 ++++\n 2 files changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/Documentation/userspace-api/media/v4l/vidioc-subdev-g-crop.rst b/Documentation/userspace-api/media/v4l/vidioc-subdev-g-crop.rst\nindex 92d933631fda..88a748103a71 100644\n--- a/Documentation/userspace-api/media/v4l/vidioc-subdev-g-crop.rst\n+++ b/Documentation/userspace-api/media/v4l/vidioc-subdev-g-crop.rst\n@@ -37,9 +37,9 @@ Description\n \n .. note::\n \n- This is an :ref:`obsolete` interface and may be removed\n- in the future. It is superseded by\n- :ref:`the selection API `.\n+ This is an :ref:`obsolete` interface and may be removed in the future. It is\n+ superseded by :ref:`the selection API `. No new\n+ extensions to the :c:type:`v4l2_subdev_crop` structure will be accepted.\n \n To retrieve the current crop rectangle applications set the ``pad``\n field of a struct :c:type:`v4l2_subdev_crop` to the\ndiff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h\nindex 7048c51581c6..81a24bd38003 100644\n--- a/include/uapi/linux/v4l2-subdev.h\n+++ b/include/uapi/linux/v4l2-subdev.h\n@@ -50,6 +50,10 @@ struct v4l2_subdev_format {\n * @rect: pad crop rectangle boundaries\n * @stream: stream number, defined in subdev routing\n * @reserved: drivers and applications must zero this array\n+ *\n+ * The subdev crop API is an obsolete interface and may be removed in the\n+ * future. It is superseded by the selection API. No new extensions to this\n+ * structure will be accepted.\n */\n struct v4l2_subdev_crop {\n \t__u32 which;\n","prefixes":[]}